Linkedin compliance removal & LinkedIn Example update/fix#397
Linkedin compliance removal & LinkedIn Example update/fix#397jtroussard merged 7 commits intomasterfrom
Conversation
singingwolfboy
left a comment
There was a problem hiding this comment.
Looks great overall! Just a few minor suggestions
docs/examples/linkedin.rst
Outdated
| >>> # Fetch the access token | ||
| >>> linkedin.fetch_token(token_url, client_secret=client_secret, | ||
| ... authorization_response=redirect_response) | ||
| >>> linkedin.fetch_token(token_url,client_secret=client_secret,include_client_id=True,authorization_response=redirect_response) |
There was a problem hiding this comment.
Can you break this across multiple lines? It's hard to read all on one line like this.
There was a problem hiding this comment.
No problem. This file as a whole is weird to me. Not sure why it was made into an .rst, and even if it's something the OC wanted documented this is sort of a pain to edit. Perhaps as a back log item for this could be to reformat these examples so that they render well in documentation yet are more user friendly e.g. pull down and hit play.
First I'm seeing f strings. I've always been happy with format method, but I'll check the docs and give these a whirl. Co-Authored-By: David Baumgold <david@davidbaumgold.com>
…ests/requests-oauthlib into linkedin-compliance-removal
docs/examples/linkedin.rst
Outdated
|
|
||
| >>> # Fetch the access token | ||
| >>> linkedin.fetch_token(token_url, client_secret=client_secret, | ||
| >>> linkedin.fetch_token(token_url,client_secret=client_secret, |
There was a problem hiding this comment.
More more nitpick: you dropped a space here, which makes it less readable
singingwolfboy
left a comment
There was a problem hiding this comment.
Looks great to me! Feel free to merge whenever you're ready.
This PR is an extension/revision of PR #388 - Upon further review and testing it has been determined that LinkedIn's API as it stands is in compliance and the compliance fixes were introducing errors in certain scenarios related to appending token codes to resource request URLs.
In short this PR includes: