Non compliant param name update/fix for LinkedIn integration.#388
Non compliant param name update/fix for LinkedIn integration.#388jtroussard wants to merge 8 commits intorequests:masterfrom jtroussard:master
Conversation
Work around to remove duplicate access token value from url in the request() method.
|
Is it related to linkedin only ? also, isn't better to not add a duplicate instead of removing once it has been added ? |
|
@JonathanHuot I have not attempted to establish authentication with any resource provider besides LinkedIn. I was hoping someone more familiar with this library would be able to provide a little more insight as to how the module determines how/when/where to add the access token string to the request URL. Any ideas/advice as how to go about finding this out? As for the present code, I was just thinking about that this morning. Your suggestion is more direct. I'll make the changes now. Thanks! |
More direct way of handling duplicate access token being added to request. Duplicate access token detection triggers log print.
|
Also, if it is strictely related to Linkedin integration, I think it deserves to be located in https://github.com/requests/requests-oauthlib/blob/master/requests_oauthlib/compliance_fixes/linkedin.py Is it possible ? Thanks |
|
@JonathanHuot The access token appending was in front of me this whole time. It looks like the "oauth_access_token" value is being added to the URL as part of the LinkedIn compliance hook routine. If that is the case I would purpose that the compliance hook |
Moved compliance hook invocation until after the access token value is added to the request URL.
compliance update access_token -> oauth_access_token
black format
|
Any advice on why my commits are failing the file Travic CI check for Black? Is that a formatting thing? If it is I've run both modules through a Black formatting. |
|
@jtroussard Yes, you can call |
|
This has been moved to #397 |
|
This has been moved to #397 |
Work around to remove duplicate access token value from url in the request() method.
Would be happy to collaborate on a more informed fix.
For more details please see issue:
access_token field added to request url when oauth2_access_token already present #377