@remotion/studio: Scroll to composition or asset when selected but out of view#6997
Merged
JonnyBurger merged 2 commits intomainfrom Apr 4, 2026
Merged
@remotion/studio: Scroll to composition or asset when selected but out of view#6997JonnyBurger merged 2 commits intomainfrom
@remotion/studio: Scroll to composition or asset when selected but out of view#6997JonnyBurger merged 2 commits intomainfrom
Conversation
…canvas only Made-with: Cursor
Contributor
|
Reviewed PR #6997 — no actionable issues found. Approved with a summary comment. Task list (8/8 completed)
|
…debar PR Made-with: Cursor
@remotion/studio: Scroll to composition or asset when selected but out of view
Contributor
There was a problem hiding this comment.
Clean PR. The scroll-into-view logic with one-shot skip flags is a nice pattern for avoiding redundant scrolls on click. The metadata-error variant in getAssetMetadata gracefully prevents the global error overlay for unsupported codecs, and the useCallback fix in useSelectAsset addresses a real referential instability. No issues found.
Big Pickle (free) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #6995 (closed).
Sidebar
scrollSidebarRowIntoViewIfNeededinsidebar-scroll-into-view.ts).mark*SidebarScrollFromRowClick).InitialCompositionLoader:useSelectAssetwrapped inuseCallback; deep-linked asset loads useselectAssetso folders expand and sidebar selection stays in sync (from@remotion/studio: Scroll selected asset and composition into view in sidebar #6995).Asset preview
getVideoMetadata()fails (e.g. unsupported codec such as ProRes in the browser), returnmetadata-errorfromgetAssetMetadata()instead of rejecting, so the global fullscreen error overlay is not triggered.ErrorLoaderand optional Retry (refetch metadata).Related
@remotion/studio: Fix calculateMetadata copy on render errors #6996 (calculateMetadata / render error copy).