Skip to content

@remotion/studio: Fix calculateMetadata copy on render errors#6996

Merged
JonnyBurger merged 1 commit intomainfrom
studio-fix-error-retry-copy
Apr 4, 2026
Merged

@remotion/studio: Fix calculateMetadata copy on render errors#6996
JonnyBurger merged 1 commit intomainfrom
studio-fix-error-retry-copy

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger commented Apr 4, 2026 •
edited
Loading

Summary

  • Root cause: CanvasOrLoading always passed calculateMetadata to ErrorLoader for both (a) render errors from RenderErrorContext and (b) composition resolution failures (resolved.type === 'error'). Only (b) is from calculateMetadata().
  • Retry button: RetryButton always said Retry calculateMetadata() even when the error was not from metadata calculation (e.g. render errors).

Changes

  • Pass calculateMetadataContext={false} for render errors and true only when showing resolution errors from calculateMetadata.
  • RetryButton accepts an optional label (default Retry). ErrorDisplay sets Retry calculateMetadata() only when calculateMetadata is true.

Related

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 4, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Apr 4, 2026 5:04pm
remotion Ready Ready Preview, Comment Apr 4, 2026 5:04pm

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Apr 4, 2026 •
edited
Loading

Reviewed PR #6996 — no actionable issues found. The fix correctly differentiates render errors from calculateMetadata() resolution errors, ensuring the retry button label and explainer are only shown in the appropriate context.

Task list (3/3 completed)
  • Review diff for correctness and potential issues
  • Self-critique drafted comments
  • Submit review or report progress

Pullfrog  ｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Big Pickle (free) ｜ 𝕏

@JonnyBurger JonnyBurger changed the title @remotion/studio: Fix calculateMetadata copy on render errors @remotion/studio: Fix calculateMetadata copy on render errors Apr 4, 2026
@JonnyBurger JonnyBurger mentioned this pull request Apr 4, 2026
Merged
@JonnyBurger JonnyBurger enabled auto-merge (squash) April 4, 2026 17:06
pullfrog[bot]
pullfrog bot reviewed Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused fix. The two error paths in CanvasOrLoading are now correctly distinguished — render errors get a generic "Retry" button while resolution errors from calculateMetadata() get the specific label and explainer. Verified that the only other ErrorLoader call site (Overlay.tsx) already passes calculateMetadata={false}, so no additional changes are needed there.

Pullfrog  ｜ View workflow run ｜ Using Big Pickle (free) ｜ 𝕏

@JonnyBurger JonnyBurger merged commit d202b5d into main Apr 4, 2026
31 of 32 checks passed
@JonnyBurger JonnyBurger deleted the studio-fix-error-retry-copy branch April 4, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pullfrog pullfrog[bot] pullfrog[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JonnyBurger