@remotion/studio: allow copying stack trace in error overlay#6966
@remotion/studio: allow copying stack trace in error overlay#6966JonnyBurger merged 4 commits intoremotion-dev:mainfrom
@remotion/studio: allow copying stack trace in error overlay#6966Conversation
|
Reviewed PR #6966 and left 4 inline comments. Key issues: Task list (7/7 completed)
|
There was a problem hiding this comment.
Three blocking issues: the Cmd+C shortcut hijacks the browser's native copy behavior, a spacer is missing between buttons, and the copied text is always the raw unsymbolicated stack — the issue explicitly asks for the symbolicated stack when available.
Big Pickle (free) ｜ 𝕏
packages/studio/src/error-overlay/remotion-overlay/CopyStackTrace.tsx
Outdated
Show resolved
Hide resolved
packages/studio/src/error-overlay/remotion-overlay/ErrorDisplay.tsx
Outdated
Show resolved
Hide resolved
packages/studio/src/error-overlay/remotion-overlay/CopyStackTrace.tsx
Outdated
Show resolved
Hide resolved
packages/studio/src/error-overlay/remotion-overlay/CopyStackTrace.tsx
Outdated
Show resolved
Hide resolved
- Replace composition selector with Copy Stacktrace control - Copy error header with symbolicated stack lines - Rename button label to Copy Stacktrace - Remove unused CompositionIdsDropdown Made-with: Cursor
|
Thank you for this contribution — the copy stack trace flow in the error overlay will be really helpful for debugging. Appreciate the work! |
Made-with: Cursor
@remotion/studio: allow copying stack trace in error overlay
Resolves #6957
What this PR does
Added a
Copy Stack Tracebutton to the Error Overlay in Studio to improve the developer experience when debugging.Key Changes & Review Fixes:
at function (file:line:column)) when available, gracefully falling back to the raw error stack if not.Cmd/Ctrl + Tusing theuseKeybindinghelper. This avoids hijacking the browser's nativeCmd/Ctrl + Ccopy behavior, allowing users to still copy individual text snippets normally.CopyStackTracecomponent with local state (idle|copied|failed) for clear visual feedback. Also ensured proper layout alignment by adding the missing spacer next to the Discord button.Looking forward to the final review! Let me know if anything else is needed.