gut: delete dead LLM provider code + zero-caller stubs#2364
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 15, 2026
Merged
gut: delete dead LLM provider code + zero-caller stubs#2364alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Remove 22 dead code files (1,161 lines) identified by disposition registry
deep audit:
MBP violations — dead LLM provider code:
- extensions/qwen-portal-auth/ (entire extension directory)
- src/agents/ollama-stream.ts (dead Ollama streaming impl, ~615 lines)
- src/agents/model-auth-markers.ts (dead credential type constants)
- src/plugin-sdk/provider-auth-result.ts (LLM OAuth builder)
- src/plugin-sdk/minimax-portal-auth.ts (dead SDK re-exports)
- src/plugin-sdk/google-gemini-cli-auth.ts (dead SDK re-exports)
- src/plugin-sdk/qwen-portal-auth.ts (dead SDK re-exports)
Zero-caller stubs (compiler-verified zero callers):
- src/agents/{cloudflare-ai-gateway,huggingface-models,models-config.providers,
skills-install-extract,synthetic-models,together-models,venice-models}.ts
- src/clawbot-cli.ts, src/memory/{index,internal}.ts
- src/secrets/provider-env-vars.ts
- src/plugin-sdk/{memory-core,memory-lancedb}.ts
- ui/src/ui/controllers/skills.ts
Also cleans up all references in: package.json exports, tsdown/vitest config,
release-check, write-plugin-sdk-entry-dts, check-no-raw-channel-fetch
allowlist, check-plugin-sdk-exports, and subpaths.test.ts.
Remaining ~95 EXCLUDE-STUB entries with live callers (forming dead code
chains where stubs import other stubs) are tracked separately.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 19, 2026
alexey-pelykh
added a commit
that referenced
this pull request
Apr 21, 2026
…ns RPC + dangling gateway methods (#2413) Closes the final AC grep gaps from #2337 after the provider/model cascade landed via #2350 / #2364 / #2373. Three classes of survivors removed: - Stale `vi.mock("../agents/model-catalog.js", ...)` block in `remoteclaw-tools.session-status.test.ts` — mocks a module deleted in #2350 - Dangling gateway method-list entries for handlers removed in #2350 — `skills.bins`, `models.list` in method-scopes.ts; `models.list`, `skills.status`, `skills.bins`, `skills.install`, `skills.update` in server-methods-list.ts - Active runtime call to `skills.bins` RPC in `node-host/runner.ts` that fails at node-host startup (handler was removed in #2350). Deletes the `SkillBinsCache` class, `resolveSkillBinTrustEntries` + `resolveExecutablePathFromEnv` helpers, the RPC call, and cascades the dead `SkillBinsProvider` / `SkillBinTrustEntry` types from `invoke-types.ts` + `invoke.ts` handler signature cleanup Also bumps `.fork-boundary-mock-baseline` 134 → 133 to lock in the improvement from removing the dead model-catalog mock. Verification: - `git grep "model-catalog\|modelSupportsVision\|loadModelCatalog" src/` → zero - `git grep "models\.list\|skills\.bins\|skillsHandlers\|modelsHandlers" src/` → zero - `pnpm check` passes, `pnpm test` passes (7010/7010), zombie-import gate passes Part of #2337. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alexey-pelykh
added a commit
that referenced
this pull request
Apr 21, 2026
…ns RPC + dangling gateway methods (#2413) (#2448) Closes the final AC grep gaps from #2337 after the provider/model cascade landed via #2350 / #2364 / #2373. Three classes of survivors removed: - Stale `vi.mock("../agents/model-catalog.js", ...)` block in `remoteclaw-tools.session-status.test.ts` — mocks a module deleted in #2350 - Dangling gateway method-list entries for handlers removed in #2350 — `skills.bins`, `models.list` in method-scopes.ts; `models.list`, `skills.status`, `skills.bins`, `skills.install`, `skills.update` in server-methods-list.ts - Active runtime call to `skills.bins` RPC in `node-host/runner.ts` that fails at node-host startup (handler was removed in #2350). Deletes the `SkillBinsCache` class, `resolveSkillBinTrustEntries` + `resolveExecutablePathFromEnv` helpers, the RPC call, and cascades the dead `SkillBinsProvider` / `SkillBinTrustEntry` types from `invoke-types.ts` + `invoke.ts` handler signature cleanup Also bumps `.fork-boundary-mock-baseline` 134 → 133 to lock in the improvement from removing the dead model-catalog mock. Verification: - `git grep "model-catalog\|modelSupportsVision\|loadModelCatalog" src/` → zero - `git grep "models\.list\|skills\.bins\|skillsHandlers\|modelsHandlers" src/` → zero - `pnpm check` passes, `pnpm test` passes (7010/7010), zombie-import gate passes Part of #2337. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2363
extensions/qwen-portal-auth/,ollama-stream.ts,model-auth-markers.ts,provider-auth-result.ts,minimax-portal-auth.ts,google-gemini-cli-auth.ts,qwen-portal-auth.tscloudflare-ai-gateway,huggingface-models,models-config.providers,skills-install-extract,synthetic-models,together-models,venice-models,clawbot-cli,memory/index,memory/internal,memory-core,memory-lancedb,provider-env-vars,ui/controllers/skillspackage.json,tsdown.config.ts,vitest.config.ts,release-check.ts,write-plugin-sdk-entry-dts.ts,check-no-raw-channel-fetch.mjs,check-plugin-sdk-exports.mjs, andsubpaths.test.ts22 files deleted, 1,161 lines removed, zero breakage.
Scope note
The issue targets 66 zero-caller stubs + 6 MBP violations (72 total). This PR
addresses all 7 MBP violations and 15 zero-caller stubs (22 total). The
remaining ~50 EXCLUDE-STUB entries have callers from other stubs (forming
dead code chains where stub A imports stub B). Those require cascading
deletion and are tracked as separate follow-up work.
Test plan
pnpm checkpasses (format + typecheck + lint)pnpm testpasses (730 suites, 6427 tests)pnpm tsgoafter deletion — no"Cannot find module" errors for any deleted file
🤖 Generated with Claude Code