Summary
Three AC greps from #2337 still fail on HEAD (2026-04-19) despite the provider/model cascade being substantively executed via #2350 / #2364 / #2373. Small cleanup PR to make #2337's original AC greps pass — unblocks closing #2337.
Gap A — Stale test mock (1 hit)
src/agents/remoteclaw-tools.session-status.test.ts:41 — vi.mock("../agents/model-catalog.js", ...) mocks a module deleted in #2350. The mock is dead (no test exercises it) but causes the AC grep to fail. Delete the 20-line mock block (lines ~41-56).
Gap B — Dangling gateway method entries (4 hits + 1 live runtime call)
Gateway advertises methods whose handlers were removed in #2350:
src/gateway/method-scopes.ts:29 — drop "skills.bins" from NODE_ROLE_METHODS
src/gateway/method-scopes.ts:62 — drop "models.list" from READ_SCOPE
src/gateway/server-methods-list.ts:39 — drop "models.list"
src/gateway/server-methods-list.ts:45-48 — drop "skills.status", "skills.bins", "skills.install", "skills.update"
And the active runtime caller:
src/node-host/runner.ts:195 — actively calls client.request<{ bins: Array<unknown> }>("skills.bins", {}). No handler exists → fails at runtime when node-host starts. Delete the SkillBinsCache instantiation, the call, and remove skillBins param plumbing from handleInvoke() callers.
AC
Expected diff
~30-50 LoC across 3-4 files. Pure deletion + minor call-site cleanup.
Relation to #2337
Closes the last AC grep gaps from #2337. Part of #2337.
Summary
Three AC greps from #2337 still fail on HEAD (2026-04-19) despite the provider/model cascade being substantively executed via #2350 / #2364 / #2373. Small cleanup PR to make #2337's original AC greps pass — unblocks closing #2337.
Gap A — Stale test mock (1 hit)
src/agents/remoteclaw-tools.session-status.test.ts:41—vi.mock("../agents/model-catalog.js", ...)mocks a module deleted in #2350. The mock is dead (no test exercises it) but causes the AC grep to fail. Delete the 20-line mock block (lines ~41-56).Gap B — Dangling gateway method entries (4 hits + 1 live runtime call)
Gateway advertises methods whose handlers were removed in #2350:
src/gateway/method-scopes.ts:29— drop"skills.bins"fromNODE_ROLE_METHODSsrc/gateway/method-scopes.ts:62— drop"models.list"fromREAD_SCOPEsrc/gateway/server-methods-list.ts:39— drop"models.list"src/gateway/server-methods-list.ts:45-48— drop"skills.status","skills.bins","skills.install","skills.update"And the active runtime caller:
src/node-host/runner.ts:195— actively callsclient.request<{ bins: Array<unknown> }>("skills.bins", {}). No handler exists → fails at runtime when node-host starts. Delete theSkillBinsCacheinstantiation, the call, and removeskillBinsparam plumbing fromhandleInvoke()callers.AC
vi.mock("../agents/model-catalog.js", ...)block removed fromremoteclaw-tools.session-status.test.tsnode-host/runner.tsno longer callsskills.binsRPC (SkillBinsCache removed)git grep -rn "model-catalog\|modelSupportsVision\|loadModelCatalog" src/returns zerogit grep -rn "models\.list\|skills\.bins\|skillsHandlers\|modelsHandlers" src/returns zeropnpm checkpassespnpm testpassesExpected diff
~30-50 LoC across 3-4 files. Pure deletion + minor call-site cleanup.
Relation to #2337
Closes the last AC grep gaps from #2337. Part of #2337.