Skip to content

gut(agents): replace default-agent display ordering with list-order semantics#2286

Merged
alexey-pelykh merged 2 commits intomainfrom
gut/replace-default-agent-display-ordering-1580
Apr 11, 2026
Merged

gut(agents): replace default-agent display ordering with list-order semantics#2286
alexey-pelykh merged 2 commits intomainfrom
gut/replace-default-agent-display-ordering-1580

Conversation

@alexey-pelykh
Copy link
Copy Markdown

Summary

  • Remove isDefault field from AgentSummary, AgentHealthSummary, and all UI types — agents now display in agents.list order with no special "default" marker
  • Strip (default) / [default] badges from all display output: health, agents list, TUI, channels add, Web UI agent panels and nodes
  • Empty agent list now shows "no agents configured" instead of creating a phantom default agent
  • Replace summaryIsDefault provider-listing flag with isSoleAgent — sole configured agent still shows all providers
  • Security fix now scans filesystem for agent directories (not just configured agents), ensuring permissions are tightened for all existing agent state

Closes #1580

Test plan

  • Type-check passes (npx tsgo --noEmit)
  • Lint passes (pnpm lint)
  • Format clean (pnpm format)
  • All 693 test files pass (5923 tests)
  • Verified no resolveDefaultAgentId references remain in any listed file
  • Verified no isDefault agent references remain in display output

🤖 Generated with Claude Code

@alexey-pelykh alexey-pelykh enabled auto-merge (squash) April 11, 2026 10:12
auto-merge was automatically disabled April 11, 2026 10:18

Pull request was closed

@alexey-pelykh alexey-pelykh reopened this Apr 11, 2026
@alexey-pelykh alexey-pelykh enabled auto-merge (squash) April 11, 2026 10:19
…emantics (#1580)

Remove the `isDefault` field from `AgentSummary` and `AgentHealthSummary`,
replace default-agent-first ordering with `agents.list` order, and strip
all "(default)" badges from display output across CLI, health, TUI, and
Web UI. Empty agent lists now show "no agents configured" instead of a
phantom default. The `summaryIsDefault` provider-listing flag becomes
`isSoleAgent` so the sole configured agent still shows all providers.
Security fix now scans the filesystem for agent directories in addition
to configured agents, ensuring permissions are tightened for all existing
agent state regardless of config presence.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-pelykh alexey-pelykh force-pushed the gut/replace-default-agent-display-ordering-1580 branch from 9ff8d86 to c5efe9a Compare April 11, 2026 10:23
@alexey-pelykh alexey-pelykh force-pushed the gut/replace-default-agent-display-ordering-1580 branch from c5efe9a to 15e7ec9 Compare April 11, 2026 14:18
@alexey-pelykh alexey-pelykh merged commit e7f555c into main Apr 11, 2026
10 checks passed
@alexey-pelykh alexey-pelykh deleted the gut/replace-default-agent-display-ordering-1580 branch April 11, 2026 14:23
alexey-pelykh added a commit that referenced this pull request Apr 24, 2026
…#2555)

Remove `agentBadgeText` function and its two call sites that rendered a
bare-text `.agent-pill` for `agentId === defaultId`. #2286 stripped the
`(default)` / `[default]` bracketed forms but left this bare pill variant
in place.

- Delete `agentBadgeText` from `ui/src/ui/views/agents-utils.ts`
- Remove the now-dead `defaultId` parameter from `buildAgentContext`,
  `renderAgentHeader`, and `renderAgentOverview` (pass-through only,
  previously fed `agentBadgeText`)
- Preserve the `.agent-pill` base class and `.agent-pill.warn` variant —
  still used by the "missing" indicator at
  `agents-panels-status-files.ts:447`
- Preserve the backend `defaultId` data flow used for agent
  pre-selection (`app-settings.ts`, `app-render.ts`, `app-chat.ts`,
  `src/commands/status.agent-local.ts`) — only the visual pill is
  removed

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gut: replace default-agent display ordering with list-order semantics

1 participant