gut(ui): strip residual 'default' agent pill badge — #2529 F3 (#2550)#2555
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 24, 2026
Merged
gut(ui): strip residual 'default' agent pill badge — #2529 F3 (#2550)#2555alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Remove `agentBadgeText` function and its two call sites that rendered a bare-text `.agent-pill` for `agentId === defaultId`. #2286 stripped the `(default)` / `[default]` bracketed forms but left this bare pill variant in place. - Delete `agentBadgeText` from `ui/src/ui/views/agents-utils.ts` - Remove the now-dead `defaultId` parameter from `buildAgentContext`, `renderAgentHeader`, and `renderAgentOverview` (pass-through only, previously fed `agentBadgeText`) - Preserve the `.agent-pill` base class and `.agent-pill.warn` variant — still used by the "missing" indicator at `agents-panels-status-files.ts:447` - Preserve the backend `defaultId` data flow used for agent pre-selection (`app-settings.ts`, `app-render.ts`, `app-chat.ts`, `src/commands/status.agent-local.ts`) — only the visual pill is removed Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2550. Removes the residual bare-text
.agent-pillrendering theword "default" in the agents sidebar list and agent header, completing
the dead-code strip that #2286 started. #2286 stripped the
(default)/[default]bracketed forms but left this pill variant inplace.
Changes
agentBadgeText()fromui/src/ui/views/agents-utils.tsui/src/ui/views/agents.tsthatconsumed its output (agents list iteration + agent header meta row)
defaultIdparameter frombuildAgentContext,renderAgentHeader, andrenderAgentOverview(pure pass-through —only fed
agentBadgeText)Preserved (explicit — per #2550 caveats):
.agent-pillbase CSS class and.agent-pill.warnvariant — stillused at
agents-panels-status-files.ts:447for the "missing"indicator
defaultIddata flow for agent pre-selection —app-settings.ts:220,app-render.ts:117/155/569,app-chat.ts,src/commands/status.agent-local.tsare untoucheddefaultIdatagents.ts:89-90Scope note
Issue #2550's scope table references
agents-utils.ts:242fordefaultIdparam removal, but line 242 there is
defaultModel?: unknowninresolveEffectiveModelFallbacks— unrelated and live. Treated as aline-number typo; the intended second
defaultIdparam isrenderAgentHeader's atagents.ts:242. Handled.Diff: 16 deletions, 0 additions across 2 files.
Test plan
pnpm check— format, tsgo, oxlint, CSS class drift audit all passpnpm test:ui:smoke— 12/12 browser-mode Chromium smoke tests pass(catches the regression class that motivated test(ui): add smoke test instantiating RemoteClawApp and asserting required host-interface fields #2495, audit(ui): missing field initializers across PollingHost/ChatHost/SettingsHost/ScrollHost/CompactionHost on RemoteClawApp #2496, test(ui): computed-style smoke test — assert sidebar/topbar/chat layout properties on rendered DOM #2519)
grep agentBadgeText ui/src→ 0 matchesgrep 'class=\"agent-pill\"' ui/src→ only.warnvariant remains(missing indicator) as intended
src/middleware/)Related: #2529 (parent audit), #2286 (prior partial gut).
🤖 Generated with Claude Code