⚠️ No Changeset found

Latest commit: 237aa7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Nothing here jumps out to me. A bit odd removing require.resolve fixes things, but shouldn't hurt.

Any particular reason why you don't go to v29? I'd be happy to help upgrading (I actually sent a PR at work 6 hours ago introducing react-router into the code base 😅 So happy to invest some time into this (and dependant) project)

@SimenB My plan was to first upgrade to v28 and make that work, but I can go straight to v29 as well if you think that would make it easier for you

I'm somehow surprised there's a difference. 😅 Breaking changes 28->29 (beyond snapshot format changes, which are configurable - and node versions) were chosen as they were negligible.

@SimenB I just didn't look into upgrading to v29 yet 🤷‍♂️
So if you say there's no real difference, I'll just go ahead and upgrade to v29 👍

Ah! Fair enough 🙂 happy to take a look if it proves troublesome - feel free to tag me 👍

@SimenB we're now getting the following warning

● Validation Warning:

Unknown option "watchPlugins" with value ["jest-watch-select-projects", "jest-watch-typeahead/filename", "jest-watch-typeahead/testname"] was found.
This is probably a typing mistake. Fixing it will remove this message.

Configuration Documentation:
https://jestjs.io/docs/configuration

Looking at the docs, I don't see what we're doing wrong tbh as watchPlugins is just there 🤔
https://jestjs.io/docs/configuration#watchplugins-arraystring--string-object

Next to that we're still getting the same read-only errors as we already had in v28

TypeError: Cannot assign to read only property 'atob' of object '[object global]'

Together with the non-constructor errors (which are probably because of the globals not being set)

TypeError: Response is not a constructor

Unknown option "watchPlugins"

sounds like jestjs/jest#13576 🙁 should probably dig deeper into it and figure out the root cause. it's just a warning tho

Next to that we're still getting the same read-only errors as we already had in v28

probably jestjs/jest#12642 (currently https://github.com/jestjs/jest/blob/642267f6848869a64861c3176eb5a6d5980639c6/packages/jest-environment-node/src/index.ts#L79-L128)

both atob and btoa are already globals in Node since v16, so I don't think you need to polyfill them at all? it should at least be done conditionally

If you want the node polyfilling and not the browser ones, you can set up a module mapper using require.resolve. Or override exportConditions: https://jestjs.io/docs/configuration#testenvironmentoptions-object

@SimenB I'm personally not a fan of overriding the exportConditions I think, as that would mean all dependencies will use the node export instead of the browser one, right?
If so, this could hide some other bugs I suppose 🤔

So I guess moduleNameMapper is the only solution here?

least hacky is probably just

if (typeof window.fetch === 'undefined') {
  require('whatwg-fetch');
}

in your jest setup or something like that. I'd say that's the least likely to hide actual bugs

🎉

🤖 Hello there,

We just published version v0.0.0-nightly-e3d5b17-20230916 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!