feat: add all available globals to test globals, not just explicit ones#12642
Merged
SimenB merged 5 commits intojestjs:mainfrom Apr 7, 2022
Merged
feat: add all available globals to test globals, not just explicit ones#12642SimenB merged 5 commits intojestjs:mainfrom
SimenB merged 5 commits intojestjs:mainfrom
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchis unflagged as global in node 18 (and flagged in v17). We should add it to our node env when availableJust looping over all globals and adding any missing seems way better than trying to keep up with node's expanding list whenever people want them.
Test plan
Green CI