Skip to content

fix(deps): update dependency http-proxy-middleware to v3#11038

Merged
Josh-Walker-GM merged 3 commits into
mainfrom
jgmw/http-proxy-middleware-v3
Jul 21, 2024
Merged

fix(deps): update dependency http-proxy-middleware to v3#11038
Josh-Walker-GM merged 3 commits into
mainfrom
jgmw/http-proxy-middleware-v3

Conversation

@Josh-Walker-GM

Copy link
Copy Markdown
Contributor

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jul 21, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the SSR milestone Jul 21, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jul 21, 2024
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review July 21, 2024 15:38
@Josh-Walker-GM

Copy link
Copy Markdown
Contributor Author

Pinging you for reference @dac09 since this is in your area. It looks like the two points in the upgrade guide that we had to watch out for were:

Removed req.url patching

I think we're okay on this one because the target in our case has no path and is just the base url of the api server.

pathRewrite (potential behaviour change)

This was a bit confusing to get my head round at first but I think it was fairly simple. You used to have to rewrite because you were rewriting the full path and so wanted to strip out the prefix used to proxy on. Now you don't have to do that and we don't need to rewrite anything as we wish to pass whatever came after the prefix to the api server.

I tested this locally with localhost:8910/.redwood/functions/.redwood/functions and you see the api side complains about no input. Switching to localhost:8910/.redwood/functions/.redwood/functionsABC instead complained about no such function .redwood. That confirmed the behaviour to me and so I removed the rewrite.

@Josh-Walker-GM

Copy link
Copy Markdown
Contributor Author

Merging this given my local testing worked well and that CI continues to be happy.

@Josh-Walker-GM Josh-Walker-GM merged commit c19bbbd into main Jul 21, 2024
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/http-proxy-middleware-v3 branch July 21, 2024 15:58
dac09 added a commit to dac09/redwood that referenced this pull request Jul 22, 2024
…-dual-pkg

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency ts-morph to v23 (redwoodjs#11044)
  chore(deps): update dependency typescript to v5.5.3 (redwoodjs#11035)
  Update saving-data.md (redwoodjs#11043)
  chore(deps): update chore (redwoodjs#11042)
  fix(deps): update dependency ts-morph to v22 (redwoodjs#11041)
  fix(deps): update dependency resend to v3 (redwoodjs#11040)
  chore(deps): update dependency lerna to v8.1.7 (redwoodjs#11039)
  fix(deps): update dependency http-proxy-middleware to v3 (redwoodjs#11038)
  chore(deps): update dependency ora to v8 (redwoodjs#11037)
  fix(deps): update dependency uuid to v10 (redwoodjs#11036)
  chore(deps): update dependency jsdom to v24.1.1 (redwoodjs#11033)
  chore(test): Document vitest issue in cli-helper test (redwoodjs#11032)
@Josh-Walker-GM Josh-Walker-GM added release:dependency This PR only updates dependencies and removed release:chore This PR is a chore (means nothing for users) labels Jul 31, 2024
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changesets-ok Override the changesets check release:dependency This PR only updates dependencies

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant