chore(test): Document vitest issue in cli-helper test#11032
Merged
Conversation
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jul 22, 2024
…-dual-pkg * 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency ts-morph to v23 (redwoodjs#11044) chore(deps): update dependency typescript to v5.5.3 (redwoodjs#11035) Update saving-data.md (redwoodjs#11043) chore(deps): update chore (redwoodjs#11042) fix(deps): update dependency ts-morph to v22 (redwoodjs#11041) fix(deps): update dependency resend to v3 (redwoodjs#11040) chore(deps): update dependency lerna to v8.1.7 (redwoodjs#11039) fix(deps): update dependency http-proxy-middleware to v3 (redwoodjs#11038) chore(deps): update dependency ora to v8 (redwoodjs#11037) fix(deps): update dependency uuid to v10 (redwoodjs#11036) chore(deps): update dependency jsdom to v24.1.1 (redwoodjs#11033) chore(test): Document vitest issue in cli-helper test (redwoodjs#11032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running into some type issues when upgrading from vitest v1 to v2.
It's a known issue with vitest, so just working around with
@ts-expect-errorfor now and providing a link to the vitest issue