Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redis/redis-py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.2.0
Choose a base ref
...
head repository: redis/redis-py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.2.1
Choose a head ref
  • 11 commits
  • 23 files changed
  • 10 contributors

Commits on Feb 25, 2026

  1. Handle connection attributes conditionally for metrics and set connec… 

    …tion data on exceptions in cluster error handling (#3964)

* Adding conditional accessing of host and port attributes from the connection for Otel metrics. Added additional handling when providing of host/port info for metrics in case of error handling in cluster execute methods

* Update redis/cluster.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update redis/cluster.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fixing unit test after applied review comment.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    @petyaslavova
    petyaslavova and Copilot committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    fc2e574 View commit details
    Browse the repository at this point in the history

  2. Fixing error handling of connection buffer purging of closed connecto… 

    …n. Enabling troubleshooting logging for maint notifications e2e tests. (#3971)

* Fixing error handling of connection buffer purging of closed connection. Enabling troubleshooting logging for maint notifications e2e tests.

* Fix race condition in RESP3 parser buffer purge (#3972)

* Initial plan

* Combine None check with try-except for buffer.purge() to handle race condition

Co-authored-by: petyaslavova <194077574+petyaslavova@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: petyaslavova <194077574+petyaslavova@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: petyaslavova <194077574+petyaslavova@users.noreply.github.com>
    @petyaslavova
    3 people committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    631c053 View commit details
    Browse the repository at this point in the history

  3. Fix protocol validation: replace finally with else and store parsed i… 

    …nt (#3965)

Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @bysiber @petyaslavova
    bysiber and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    bb2b6f3 View commit details
    Browse the repository at this point in the history

  4. Return copies from _get_free/in_use_connections and fix async _mock (#… 

    …3967)

Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @bysiber @petyaslavova
    bysiber and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    abc519d View commit details
    Browse the repository at this point in the history

  5. Add missing shard channel message types to async PubSub (#3966) 

    Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @bysiber @petyaslavova
    bysiber and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    1958065 View commit details
    Browse the repository at this point in the history

  6. Fix issues with ClusterPipeline connection management (#3804) 

    * Fix connection leak & dirty connection reuse

* Add tests for connection leak and dirty connection reuse bugs

* Add comment

* Update redis/cluster.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fixing tests

---------

Co-authored-by: petyaslavova <petya.slavova@redis.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    @praboud @petyaslavova
    3 people committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    f02c66b View commit details
    Browse the repository at this point in the history

  7. fix(pubsub): avoid UnicodeDecodeError on reconnect with binary channe… 

    …l names (#3944)

* fix(pubsub): avoid UnicodeDecodeError on reconnect with binary channel names

Channels subscribed as positional arguments (without a callback handler)
may carry binary names that are not valid in the connection's encoding
(e.g. arbitrary bytes that are not valid UTF-8).  The existing
`on_connect` method decoded every channel name via `force=True` to pass
them as keyword arguments to `subscribe`/`psubscribe`, which raised
`UnicodeDecodeError` for these channels.

Split the reconnection logic: channels with handlers are decoded and
passed as kwargs (they were originally subscribed as kwargs, so their
names are guaranteed decodable); channels without handlers are passed as
positional args, preserving the original bytes.

Applied the same fix to:
- async PubSub.on_connect (channels and patterns)
- sync PubSub.on_connect (channels, patterns, and shard_channels)

Added tests for binary channel and pattern reconnection in both sync
and async test suites.

Fixes #3912

* Applying review comments.

---------

Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @skylarkoo7 @petyaslavova
    skylarkoo7 and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    2098114 View commit details
    Browse the repository at this point in the history

  8. Removed batch_size and consumer_name attributes from OTel metrics (#3978 

    )

* Removed batch_size and consumer_name attributes from OTel metrics

* Exclude args from linters

* Left only #noqa
    @vladvildanov @petyaslavova
    vladvildanov authored and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    a21f768 View commit details
    Browse the repository at this point in the history

  9. Hold references to ClusterNode disconnect task (#3826) 

    * Hold references to ClusterNode disconnect task

* Fix linters

---------

Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @rhoboro @petyaslavova
    rhoboro and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    e203796 View commit details
    Browse the repository at this point in the history

  10. remove remaining imports of typing_extensions (#3873) 

    * remove remaining imports of typing_extensions

* Applying review comments

---------

Co-authored-by: petyaslavova <petya.slavova@redis.com>
    @dotlambda @petyaslavova
    dotlambda and petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    c671fd9 View commit details
    Browse the repository at this point in the history

  11. Updating lib version to 7.2.1

    @petyaslavova
    petyaslavova committed Feb 25, 2026
    Configuration menu
    Copy the full SHA
    56859cf View commit details
    Browse the repository at this point in the history
Loading