Fix protocol validation: replace finally with else and store parsed int#3965
Merged
petyaslavova merged 2 commits intoredis:masterfrom Feb 20, 2026
Merged
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
petyaslavova
added a commit
that referenced
this pull request
Feb 25, 2026
…nt (#3965) Co-authored-by: petyaslavova <petya.slavova@redis.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues in the protocol validation logic during connection initialization:
1.
finallyblock causesUnboundLocalErrorwhenValueErroris raisedWhen
protocolis a non-numeric string like"abc",int(protocol)raisesValueError. Theexcept ValueErrorclause re-raises asConnectionError. But thefinallyblock always executes — andpwas never assigned, sop < 2raisesUnboundLocalError, replacing the meaningful error message with a confusing one.Changed
finallytoelseso the range check only runs after successful parsing.2. Async connection stores raw
protocolinstead of parsedpThe sync version correctly does
self.protocol = p(the validated integer), but the async version hadself.protocol = protocol(the raw input, which could be a string). This forces workarounds throughout the async codebase (self.protocol not in [2, "2"],int(self.protocol), etc.). Fixed to store the parsed integerp, consistent with the sync version.