Add missing shard channel message types to async PubSub#3966
Merged
petyaslavova merged 2 commits intoredis:masterfrom Feb 22, 2026
Merged
Add missing shard channel message types to async PubSub#3966petyaslavova merged 2 commits intoredis:masterfrom
petyaslavova merged 2 commits intoredis:masterfrom
Conversation
petyaslavova
added a commit
that referenced
this pull request
Feb 25, 2026
Co-authored-by: petyaslavova <petya.slavova@redis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async
PubSubclass is missing"smessage"inPUBLISH_MESSAGE_TYPESand"sunsubscribe"inUNSUBSCRIBE_MESSAGE_TYPES. The sync version already has these for Redis 7.0+ shard channel support.Without them, incoming
smessagemessages from shard channel subscriptions are not recognized as publish messages, so registered callbacks are never invoked. Similarly,sunsubscribeconfirmations are not handled, leaving theshard_channelsdict andpending_unsubscribe_shard_channelsset uncleaned — a memory leak over the lifetime of the PubSub instance.