Skip to content

fix: remove unnecessary case-sensitivity when working with commands#2036

Merged
PavelPashov merged 2 commits intoredis:mainfrom
pinkiesky:fix-1933-keyPrefix
Nov 7, 2025
Merged

fix: remove unnecessary case-sensitivity when working with commands#2036
PavelPashov merged 2 commits intoredis:mainfrom
pinkiesky:fix-1933-keyPrefix

Conversation

@pinkiesky
Copy link
Contributor

This is the fix for #1933 ('keyPrefix' not working when command is in capital letter)

What is the root cause of the issue: to add prefix for keys, ioredis should get key position for a specific command. However, exists, hasFlag, and getKeyIndexes are case-sensitive by default. Case-insensitivity will fix the issue

This PR should be merged after ioredis/commands#7 is merged

@jit-ci
Copy link

jit-ci bot commented Oct 31, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@PavelPashov
Copy link
Contributor

Hey @pinkiesky, thank you for creating this PR, I will take a look

@PavelPashov
Copy link
Contributor

PavelPashov commented Nov 3, 2025

Hey @pinkiesky, ioredis/commands 1.5.0 has been released, please update this PR.

@pinkiesky
Copy link
Contributor Author

Hey @pinkiesky, ioredis/commands 1.5.0 has been released, please update this PR.

@PavelPashov , done

Copy link
Contributor

@PavelPashov PavelPashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PavelPashov PavelPashov merged commit f33a2c8 into redis:main Nov 7, 2025
15 checks passed
@PavelPashov
Copy link
Contributor

Hey @pinkiesky, we'll include this in the next release

simong added a commit to simong/ioredis that referenced this pull request Nov 17, 2025
* origin/main:
  fix: remove unnecessary case-sensitivity when working with commands (redis#2036)
  ci: update redis test images (redis#2035)
github-actions bot pushed a commit that referenced this pull request Jan 5, 2026
# [5.9.0](v5.8.2...v5.9.0) (2026-01-05)

### Bug Fixes

* remove unnecessary case-sensitivity when working with commands ([#2036](#2036)) ([f33a2c8](f33a2c8))

### Features

* add timeout blocking commands ([#2052](#2052)) ([6ec78be](6ec78be))
* **cluster:** refactor sharded pub/sub v5 ([#2043](#2043)) ([a523f3a](a523f3a))
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants