impl: caseInsensitive option for each function#7
Merged
PavelPashov merged 1 commit intoioredis:mainfrom Nov 3, 2025
Merged
Conversation
Collaborator
|
Hey @pinkiesky, thanks for working on this! It’d be great to have both PRs to review together. |
Contributor
Author
|
Hi @PavelPashov, |
PavelPashov
approved these changes
Nov 3, 2025
Collaborator
PavelPashov
left a comment
There was a problem hiding this comment.
Looks good, thank you for the contribution
Contributor
Author
|
@PavelPashov, could you merge this PR? It looks like I have no access or so Or this PR need one more approval, I'm not sure 🤔 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
# [1.5.0](v1.4.0...v1.5.0) (2025-11-03) ### Features * caseInsensitive option for each function ([#7](#7)) ([4f89cfe](4f89cfe))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. I want to fix redis/ioredis#1933 ('keyPrefix' not working when command is in capital letter)
What is the root cause of the issue: to add prefix for keys, ioredis should get key position for a specific command. However,
exists,hasFlag, andgetKeyIndexesare case-sensitive by default. Case-insensitivity will fix the issue (I tested it locally)That is the reason why this PR appear :)
So, after we merge this PR, I will prepare the ioredis counterpart of the fix
P.S. I didn't change the default behaviour of the function and added an option for the sake of not ruin the compatibility somewhere