Skip to content
/ rector-src Public

[PostRector] Skip remove unused used at @see for Generic tag #3562

Merged
samsonasik merged 3 commits intomainfrom
skip-used-see
Apr 5, 2023
Merged

[PostRector] Skip remove unused used at @see for Generic tag #3562
samsonasik merged 3 commits intomainfrom
skip-used-see

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Apr 4, 2023 •
edited
Loading

The following code should be skipped from remove unused use:

namespace Rector\Core\Tests\Issues\NamespacedUse\Fixture;

use Rector\Renaming\Rector\Name\RenameClassRector;

/**
 * @see RenameClassRector
 */
final class SkipUsedSee
{
}

@samsonasik samsonasik requested a review from TomasVotruba as a code owner April 4, 2023 23:14
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 4, 2023

PHPStan error seems due to new PHPStan release: https://github.com/phpstan/phpstan/releases/tag/1.10.11

4s
Run vendor/bin/phpstan
Note: Using configuration file /home/runner/work/rector-src/rector-src/phpstan.neon.
   0/198 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 198/198 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Error: Method Rector\PHPUnit\NodeFinder\DataProviderClassMethodFinder::resolveParentAbstractClasses() should return array<PhpParser\Node\Stmt\Class_> but returns array<int<0, max>, PhpParser\Node\Stmt\Class_|PhpParser\Node\Stmt\Enum_|PhpParser\Node\Stmt\Interface_|PhpParser\Node\Stmt\Trait_|null>.
 ------ ----------------------------------------------------------------------------------------------------------------------- 
  Line   src/NodeFinder/DataProviderClassMethodFinder.php                                                                       
 ------ ----------------------------------------------------------------------------------------------------------------------- 
  124    Method                                                                                                                 
         Rector\PHPUnit\NodeFinder\DataProviderClassMethodFinder::resolveParentAbstractClasses()                                
         should return array<PhpParser\Node\Stmt\Class_> but returns                                                            
         array<int<0, max>,                                                                                                     
         PhpParser\Node\Stmt\Class_|PhpParser\Node\Stmt\Enum_|PhpParser\Node\Stmt\Interface_|PhpParser\Node\Stmt\Trait_|null>.

@samsonasik samsonasik mentioned this pull request Apr 4, 2023
Merged
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 4, 2023

Ref rectorphp/rector-phpunit#166 for resolve phpstan notice

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 4, 2023

Restarting build

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 4, 2023

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 5, 2023

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit be24410 into main Apr 5, 2023
@samsonasik samsonasik deleted the skip-used-see branch April 5, 2023 00:11
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[PostRector] Skip remove unused used at @see for Generic tag (#3562)
35fcacb 
* [PostRector] Skip remove unused used at @see for Generic tag

* fixture

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samsonasik