Skip to content

Fix phpstan notice on update to phpstan 1.10.11#166

Merged
samsonasik merged 2 commits intomainfrom
fix-phpstan
Apr 4, 2023
Merged

Fix phpstan notice on update to phpstan 1.10.11#166
samsonasik merged 2 commits intomainfrom
fix-phpstan

Conversation

@samsonasik
Copy link
Copy Markdown
Member

After update to phpstan 1.10.11, there is notice:

➜  rector-phpunit git:(main) composer phpstan
> vendor/bin/phpstan analyse --ansi --error-format symplify
Note: Using configuration file /Users/samsonasik/www/rector-phpunit/phpstan.neon.
 198/198 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  src/NodeFinder/DataProviderClassMethodFinder.php:124
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  - '#Method Rector\\PHPUnit\\NodeFinder\\DataProviderClassMethodFinder\:\:resolveParentAbstractClasses\(\) should return array<PhpParser\\Node\\Stmt\\Class_> but returns array<int<0, max>, PhpParser\\Node\\Stmt\\Class_\|PhpParser\\Node\\Stmt\\Enum_\|PhpParser\\Node\\Stmt\\Interface_\|PhpParser\\Node\\Stmt\\Trait_\|null>#'
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


                                                                                                                        
 [ERROR] Found 1 errors                                                                                                 
                                                                                                                        

Script vendor/bin/phpstan analyse --ansi --error-format symplify handling the phpstan event returned with error code 1

This PR resolve it. Ref rectorphp/rector-src#3562 (comment)

@samsonasik samsonasik enabled auto-merge (squash) April 4, 2023 23:27
@samsonasik samsonasik merged commit 8a1a163 into main Apr 4, 2023
@samsonasik samsonasik deleted the fix-phpstan branch April 4, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant