• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch infiniteloop

Reviewing files that changed from the base of the PR and between 0c3ffe3 and 95eb39f.

• src/cartesian/Line.tsx (2 hunks)
• src/state/SetTooltipEntrySettings.tsx (2 hunks)
• src/state/tooltipSlice.ts (2 hunks)
• test/hooks/useActiveTooltipDataPoints.spec.tsx (1 hunks)

• GitHub Check: Build, Test, Pack
• GitHub Check: Analyze (javascript-typescript)

src/cartesian/Line.tsx (1)

176-194: LGTM! Consistent destructuring pattern.

The changes improve code consistency by destructuring tooltipType from props and using local variables instead of accessing via props.*. This aligns with the existing pattern for other properties like stroke.

test/hooks/useActiveTooltipDataPoints.spec.tsx (1)

351-379: LGTM! Test effectively validates the infinite loop fix.

The test directly addresses issue #6613 by rendering a Line with an inline activeDot object (which creates a new object reference on every render). If the infinite loop regression occurs, this test would timeout or fail. The test structure follows established patterns and uses the createSelectorTestCase helper as recommended.

Based on learnings

src/state/tooltipSlice.ts (1)

274-285: LGTM! Reducer correctly replaces tooltip entry settings.

The reducer uses reference equality via indexOf to locate the previous configuration, which works correctly since SetTooltipEntrySettings.tsx maintains the exact reference in prevSettingsRef. The use of current(state) and castDraft is appropriate for Immer's draft state handling, and the conditional update (index > -1) gracefully handles edge cases.

src/state/SetTooltipEntrySettings.tsx (2)

21-33: LGTM! Core fix successfully prevents infinite loop.

The effect correctly implements the optimization:

1. First render: Dispatches addTooltipEntrySettings and stores the reference
2. Subsequent renders: Dispatches replaceTooltipEntrySettings to update in-place rather than adding new entries

By replacing instead of accumulating entries, the tooltip payload array maintains constant size even when props like activeDot are new objects on every render. This breaks the infinite loop described in issue #6613.

The comparison at line 29 (prevSettingsRef.current !== tooltipEntrySettings) will always be true since fn(args) creates a new object each time, but this is intentional—the replacement ensures we update with the latest settings while maintaining array size.

---

35-42: LGTM! Cleanup effect correctly handles unmounting.

The separate cleanup effect with [dispatch] dependencies is the right approach. This ensures:

• The cleanup only runs on unmount (or when dispatch changes, which is rare)
• When fn, args, or isPanorama change, we replace the entry in-place rather than removing and re-adding it
• The last known prevSettingsRef.current is properly cleaned up on unmount

If this cleanup were combined with the main effect, it would trigger unnecessary remove/add cycles on every prop change, potentially causing flickering or performance issues.