src/cartesian/Funnel.tsx (1)

127-163: Funnel tooltip wiring looks good; consider aligning with resolved defaults

The new SetFunnelTooltipEntrySettings correctly captures dataDefinedOnItem, per-trapezoid positions, and the expected settings fields, and using trapezoids for positions is a nice improvement.

One minor thing to consider: at the call site you pass props.stroke, props.fill, and props.hide, while the rendered FunnelWithState uses the values from resolveDefaultProps. If callers omit these props and rely on defaultFunnelProps, the tooltip configuration will see stroke/fill/hide as undefined, so tooltip color/hidden state might not fully mirror the actual funnel appearance. If you want them to stay in sync even when only defaults are used, you could pass the resolved stroke/fill/hide values into SetFunnelTooltipEntrySettings instead.

Also applies to: 385-400, 439-450

src/polar/Pie.tsx (1)

261-294: LGTM! Consider adding displayName for easier debugging.

The memoized component pattern correctly fixes the tooltip state bug by ensuring stable references. The component will only re-render when its props change, creating a new tooltipEntrySettings object that triggers the reference-based comparison in SetTooltipEntrySettings.

Consider adding a displayName to improve the debugging experience:

 const SetPieTooltipEntrySettings = React.memo(
   ({
     dataKey,
     nameKey,
     sectors,
     stroke,
     strokeWidth,
     fill,
     name,
     hide,
     tooltipType,
   }: Pick<
     InternalProps,
     'dataKey' | 'nameKey' | 'sectors' | 'stroke' | 'strokeWidth' | 'fill' | 'name' | 'hide' | 'tooltipType'
   >) => {
     const tooltipEntrySettings: TooltipPayloadConfiguration = {
       dataDefinedOnItem: sectors.map((p: PieSectorDataItem) => p.tooltipPayload),
       positions: sectors.map((p: PieSectorDataItem) => p.tooltipPosition),
       settings: {
         stroke,
         strokeWidth,
         fill,
         dataKey,
         nameKey,
         name: getTooltipNameProp(name, dataKey),
         hide,
         type: tooltipType,
         color: fill,
         unit: '', // why doesn't Pie support unit?
       },
     };
     return <SetTooltipEntrySettings tooltipEntrySettings={tooltipEntrySettings} />;
   },
 );
+SetPieTooltipEntrySettings.displayName = 'SetPieTooltipEntrySettings';

src/chart/Sankey.tsx (1)

443-471: LGTM! Consistent with the refactoring pattern.

The implementation correctly follows the same memoized component pattern as other chart components. Consider adding displayName for debugging consistency across the codebase.

 const SetSankeyTooltipEntrySettings = React.memo(
   ({
     dataKey,
     nameKey,
     stroke,
     strokeWidth,
     fill,
     name,
     data,
   }: Pick<Props, 'dataKey' | 'nameKey' | 'stroke' | 'strokeWidth' | 'fill' | 'name' | 'data'>) => {
     const tooltipEntrySettings: TooltipPayloadConfiguration = {
       dataDefinedOnItem: data,
       positions: undefined,
       settings: {
         stroke,
         strokeWidth,
         fill,
         dataKey,
         name,
         nameKey,
         hide: false,
         type: undefined,
         color: fill,
         unit: '',
       },
     };
     return <SetTooltipEntrySettings tooltipEntrySettings={tooltipEntrySettings} />;
   },
 );
+SetSankeyTooltipEntrySettings.displayName = 'SetSankeyTooltipEntrySettings';

src/cartesian/Line.tsx (1)

176-209: LGTM! Consistent refactoring pattern.

The Line component correctly implements the memoized tooltip configuration pattern. Consider adding displayName for consistency with other components.

+SetLineTooltipEntrySettings.displayName = 'SetLineTooltipEntrySettings';

src/cartesian/Scatter.tsx (1)

218-258: LGTM! Well-structured with clear type definitions.

The Scatter component introduces a dedicated type InputRequiredToComputeTooltipEntrySettings which improves type clarity. The comment on Line 253 about unit support is helpful. Consider adding displayName for debugging.

+SetScatterTooltipEntrySettings.displayName = 'SetScatterTooltipEntrySettings';

src/chart/Treemap.tsx (1)

544-570: LGTM! Correctly handles Treemap's stateful nature.

The component appropriately accepts currentRoot from Treemap's component state, ensuring tooltip configuration updates when navigation changes. The TODO comment on Line 554 provides helpful context. Consider adding displayName.

+SetTreemapTooltipEntrySettings.displayName = 'SetTreemapTooltipEntrySettings';

src/chart/SunburstChart.tsx (1)

126-158: LGTM! Correctly handles Map serialization.

The conversion from Map to Record on Line 140 is necessary for Redux store compatibility, and the comment clearly explains this. The implementation follows the established pattern. Consider adding displayName.

+SetSunburstTooltipEntrySettings.displayName = 'SetSunburstTooltipEntrySettings';

src/cartesian/Area.tsx (1)

195-228: LGTM! Completes the consistent refactoring pattern.

The Area component correctly implements the memoized tooltip configuration, completing the PR-wide refactoring. Consider adding displayName for debugging consistency.

+SetAreaTooltipEntrySettings.displayName = 'SetAreaTooltipEntrySettings';

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro