fix: get default export working in both ESM/CJS#799
Merged
kanadgupta merged 10 commits intomainfrom Sep 25, 2023
Merged
Conversation
eslint has been silently failing for a while now 😬
This reverts commit f090f18.
7 tasks
kanadgupta
added a commit
that referenced
this pull request
Sep 25, 2023
This reverts commit 25a04c4.
Merged
kanadgupta
added a commit
that referenced
this pull request
Sep 25, 2023
kanadgupta
added a commit
that referenced
this pull request
Sep 25, 2023
kanadgupta
added a commit
that referenced
this pull request
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We use this library called
tsupto bundle this library and according to Are The Types Wrong, CJS doesn't like when we haveexport defaultand non-defaultexports in the same file — this might be an issue withtsupor it might be an issue with CJS/ESM dual exported packages more broadly, not sure.This PR removes the non-default
exportsfrom our main entrypoint file (i.e.,src/index.ts), as well as consolidates the exports in ourutilsfile. There are other improvements to be made but these ones seemed like the most straightforward.I broke this out from the change in #798 since it feels like a breaking change.EDIT: after sleeping on it, I've decided this is technically a patch since it's fixing an issue with our existing v21 release.🧬 QA & Testing
Do tests still pass?
Here's the before and after, using the Are The Types Wrong CLI (note the
node16 (from CJS)column for theoasandoas/utilslines):In
main:This PR: