fix(tsup): drop treeshaking flag, lint fixes#798
Merged
kanadgupta merged 6 commits intomainfrom Sep 22, 2023
Merged
Conversation
eslint has been silently failing for a while now 😬
treeshaking flag, lint fixes
darrenyong
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This PR fixes up an issue where this library doesn't play nicely if you try to import it via CommonJS (I discovered that the
treeshakingflag is problematic in readmeio/fetch-har#427)And totally unrelated to the above: fixed up our CI scripts a bit since we were silently failing an ESLint check 😬
🧬 QA & Testing
If tests pass we should be in good shape!