fix: preserve legacy syntax for legacy variables#1365
Merged
Conversation
rafegoldberg
approved these changes
Feb 26, 2026
Contributor
rafegoldberg
left a comment
There was a problem hiding this comment.
Double checked this regex; looks good to me.
| const STRIP_TAGS = ['script', 'style']; | ||
|
|
||
| /** Valid JS identifier: starts with $, _, or a letter; followed by $, _, letters, digits, etc. */ | ||
| const JS_IDENTIFIER_RE = /^[$_\p{L}][$_\p{L}\p{Mn}\p{Mc}\p{Nd}\p{Pc}\u200C\u200D]*$/u; |
Contributor
There was a problem hiding this comment.
Personally, but I'd rename this to VALID_IDENTIFIER_REGEX, since the "JS" part is kinda implied and "RE" doesn't immediately scan. But again, just nitpicking!
rafegoldberg
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Version 13.4.0 ### ✨ New & Improved * **mdxish:** preserve jsx expressions in ast processor ([#1332](#1332)) ([7704aaa](7704aaa)) ### 🛠 Fixes & Updates * focus on code copy button ([#1352](#1352)) ([6853be1](6853be1)) * **stripComments:** not escape checkbox ([#1360](#1360)) ([a4226c2](a4226c2)) * preserve legacy syntax for legacy variables ([#1365](#1365)) ([d735a99](d735a99)) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v13.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Since we can now distinguish legacy variable vs mdx variable (#1340), as well as allowing wild variables in bracket notation (https://github.com/readmeio/readme/pull/17315). We should add support for plain to keep original syntax as is, instead of serialising everything to {user.}.
🧬 QA & Testing
Unit tests