fix(stripComments): not escape checkbox#1360
Merged
eaglethrost merged 1 commit intonextfrom Feb 25, 2026
Merged
Conversation
eaglethrost
commented
Feb 25, 2026
| ['unordered list trailing space', '- A <!-- c -->\n- B', undefined, '* A \n* B'], | ||
| ['between list items', '- Item 1\n<!-- c -->\n- Item 2', undefined, '* Item 1\n\n- Item 2'], | ||
| ['table cells', '| H1 | H2 |\n| :- | :- |\n| <!-- c --> | data |', undefined, '| H1 | H2 |\n| :- | :- |\n| | data |'], | ||
| ['table cells', '| H1 | H2 |\n| :- | :- |\n| <!-- c --> | data |', undefined, '| H1 | H2 |\n| :- | :--- |\n| | data |'], |
Contributor
Author
There was a problem hiding this comment.
A bit of side effect, but when rendering this the display look exactly the same
kevinports
approved these changes
Feb 25, 2026
rafegoldberg
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Version 13.4.0 ### ✨ New & Improved * **mdxish:** preserve jsx expressions in ast processor ([#1332](#1332)) ([7704aaa](7704aaa)) ### 🛠 Fixes & Updates * focus on code copy button ([#1352](#1352)) ([6853be1](6853be1)) * **stripComments:** not escape checkbox ([#1360](#1360)) ([a4226c2](a4226c2)) * preserve legacy syntax for legacy variables ([#1365](#1365)) ([d735a99](d735a99)) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v13.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Checkboxes are currently not being rendered in non-admin view when sanitise comment is on (in all legacy, mdx, mdxish projects). The root cause of this is because of the
remarkParseandremarkStringifyplugins in the stripComments pipeline which escapes [ ]. The fix is to use remark pluginremarkGmto parse checkboxes correctly in the pipeline. This should be safe to do as it's just an extension of the pipeline to support GFM syntax, which checkbox is.🧬 QA & Testing