Skip to content

Refactor of RCTTVRemoteHandler#221

Merged
douglowder merged 1 commit intotvos-v0.64.2from
dlowder/rnn-menucontrol
Sep 18, 2021
Merged

Refactor of RCTTVRemoteHandler#221
douglowder merged 1 commit intotvos-v0.64.2from
dlowder/rnn-menucontrol

Conversation

@douglowder
Copy link
Copy Markdown
Collaborator

@douglowder douglowder commented Sep 17, 2021

Fix #69 (react-native-navigation issues)

  • RCTRootView code to attach TV remote handler is now wrapped inside RCTTVRemoteHandler
  • TV remote handler now has global state to track whether menu key should be enabled
  • TV remote handler now also listens for TVMenuControl notifications, so views that create a TV event handler no longer have to do anything else

Test Plan

Tested with the unit and integration tests, RNTester manual testing, new project testing, and testing against react-native-navigation.

@douglowder douglowder force-pushed the dlowder/rnn-menucontrol branch 2 times, most recently from cc2e559 to 58eed23 Compare September 18, 2021 18:12
Fix #69 (react-native-navigation issues)

- RCTRootView code to attach TV remote handler is now wrapped inside RCTTVRemoteHandler
- TV remote handler now has global state to track whether menu key should be enabled
@douglowder douglowder force-pushed the dlowder/rnn-menucontrol branch from 58eed23 to f73de7a Compare September 18, 2021 18:17
@douglowder douglowder merged commit 5310617 into tvos-v0.64.2 Sep 18, 2021
douglowder added a commit that referenced this pull request Jan 1, 2022
Fix #69 (react-native-navigation issues)

- RCTRootView code to attach TV remote handler is now wrapped inside RCTTVRemoteHandler
- TV remote handler now has global state to track whether menu key should be enabled
@douglowder douglowder deleted the dlowder/rnn-menucontrol branch June 19, 2024 19:58
douglowder pushed a commit that referenced this pull request Nov 15, 2025
Summary:
Pull Request resolved: facebook/react-native#54483

Changelog: [Internal] - Update `react-native/debugger-frontend` from d8824de...e1dd7af

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@d8824de...e1dd7af).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [e1dd7af90](facebook/react-native-devtools-frontend@e1dd7af90) | Alex Hunt (hello@alexhunt.dev) | 2025-11-10T18:06:01+00:00 | [Remove network experiment and experimental icon (#220)](facebook/react-native-devtools-frontend@e1dd7af90) |
| [e1743557e](facebook/react-native-devtools-frontend@e1743557e) | Alex Hunt (hello@alexhunt.dev) | 2025-11-07T18:02:38+00:00 | [Update Network list to use x-fb-friendly-name header (#221)](facebook/react-native-devtools-frontend@e1743557e) |
| [59c63cbe2](facebook/react-native-devtools-frontend@59c63cbe2) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T19:13:11+00:00 | [Add conditional disabling of features incompatible with multiple hosts (#218)](facebook/react-native-devtools-frontend@59c63cbe2) |
| [d37d4264b](facebook/react-native-devtools-frontend@d37d4264b) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T18:01:59+00:00 | [Add experimental Perf Issues sub-panel (#217)](facebook/react-native-devtools-frontend@d37d4264b) |

Reviewed By: cipolleschi

Differential Revision: D86685451

fbshipit-source-id: 7f417f50eaa7fdd0de85ac05fc883806a011d308
douglowder pushed a commit that referenced this pull request Nov 15, 2025
Summary:
Pull Request resolved: facebook/react-native#54483

Changelog: [Internal] - Update `react-native/debugger-frontend` from d8824de...e1dd7af

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@d8824de...e1dd7af).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [e1dd7af90](facebook/react-native-devtools-frontend@e1dd7af90) | Alex Hunt (hello@alexhunt.dev) | 2025-11-10T18:06:01+00:00 | [Remove network experiment and experimental icon (#220)](facebook/react-native-devtools-frontend@e1dd7af90) |
| [e1743557e](facebook/react-native-devtools-frontend@e1743557e) | Alex Hunt (hello@alexhunt.dev) | 2025-11-07T18:02:38+00:00 | [Update Network list to use x-fb-friendly-name header (#221)](facebook/react-native-devtools-frontend@e1743557e) |
| [59c63cbe2](facebook/react-native-devtools-frontend@59c63cbe2) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T19:13:11+00:00 | [Add conditional disabling of features incompatible with multiple hosts (#218)](facebook/react-native-devtools-frontend@59c63cbe2) |
| [d37d4264b](facebook/react-native-devtools-frontend@d37d4264b) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T18:01:59+00:00 | [Add experimental Perf Issues sub-panel (#217)](facebook/react-native-devtools-frontend@d37d4264b) |

Reviewed By: cipolleschi

Differential Revision: D86685451

fbshipit-source-id: 7f417f50eaa7fdd0de85ac05fc883806a011d308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TVMenuControl module isn't working with React Native Navigation.

1 participant