Refactor of TV remote handler and TVMenuControl#220
Closed
douglowder wants to merge 2 commits intotvos-v0.64.2from
Closed
Refactor of TV remote handler and TVMenuControl#220douglowder wants to merge 2 commits intotvos-v0.64.2from
douglowder wants to merge 2 commits intotvos-v0.64.2from
Conversation
Needed for React Native Navigation to work with TVMenuControl (#69)
Collaborator
Author
|
Closing this due to some subtle memory allocation issues -- will file a PR with a slightly different approach that avoids this issue. |
douglowder
pushed a commit
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: facebook/react-native#54483 Changelog: [Internal] - Update `react-native/debugger-frontend` from d8824de...e1dd7af Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@d8824de...e1dd7af). ### Changelog | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [e1dd7af90](facebook/react-native-devtools-frontend@e1dd7af90) | Alex Hunt (hello@alexhunt.dev) | 2025-11-10T18:06:01+00:00 | [Remove network experiment and experimental icon (#220)](facebook/react-native-devtools-frontend@e1dd7af90) | | [e1743557e](facebook/react-native-devtools-frontend@e1743557e) | Alex Hunt (hello@alexhunt.dev) | 2025-11-07T18:02:38+00:00 | [Update Network list to use x-fb-friendly-name header (#221)](facebook/react-native-devtools-frontend@e1743557e) | | [59c63cbe2](facebook/react-native-devtools-frontend@59c63cbe2) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T19:13:11+00:00 | [Add conditional disabling of features incompatible with multiple hosts (#218)](facebook/react-native-devtools-frontend@59c63cbe2) | | [d37d4264b](facebook/react-native-devtools-frontend@d37d4264b) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T18:01:59+00:00 | [Add experimental Perf Issues sub-panel (#217)](facebook/react-native-devtools-frontend@d37d4264b) | Reviewed By: cipolleschi Differential Revision: D86685451 fbshipit-source-id: 7f417f50eaa7fdd0de85ac05fc883806a011d308
douglowder
pushed a commit
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: facebook/react-native#54483 Changelog: [Internal] - Update `react-native/debugger-frontend` from d8824de...e1dd7af Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebook/react-native-devtools-frontend@d8824de...e1dd7af). ### Changelog | Commit | Author | Date/Time | Subject | | ------ | ------ | --------- | ------- | | [e1dd7af90](facebook/react-native-devtools-frontend@e1dd7af90) | Alex Hunt (hello@alexhunt.dev) | 2025-11-10T18:06:01+00:00 | [Remove network experiment and experimental icon (#220)](facebook/react-native-devtools-frontend@e1dd7af90) | | [e1743557e](facebook/react-native-devtools-frontend@e1743557e) | Alex Hunt (hello@alexhunt.dev) | 2025-11-07T18:02:38+00:00 | [Update Network list to use x-fb-friendly-name header (#221)](facebook/react-native-devtools-frontend@e1743557e) | | [59c63cbe2](facebook/react-native-devtools-frontend@59c63cbe2) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T19:13:11+00:00 | [Add conditional disabling of features incompatible with multiple hosts (#218)](facebook/react-native-devtools-frontend@59c63cbe2) | | [d37d4264b](facebook/react-native-devtools-frontend@d37d4264b) | Alex Hunt (hello@alexhunt.dev) | 2025-11-06T18:01:59+00:00 | [Add experimental Perf Issues sub-panel (#217)](facebook/react-native-devtools-frontend@d37d4264b) | Reviewed By: cipolleschi Differential Revision: D86685451 fbshipit-source-id: 7f417f50eaa7fdd0de85ac05fc883806a011d308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for React Native Navigation to work with TVMenuControl (#69)
Summary
Refactor
RCTTVRemoteHandlerto make it a singleton (which matches its expected behavior), and create a simple wrapper to add its gesture handlers to a view. This is needed to fix some issues withreact-native-navigationinteroperability with the Apple TV remote handler.Test Plan
Will test this extensively on both an RNN test project and other React Native TV projects, and also check that all the usual integration tests pass.