-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
uses thumbStyle.transform values in the thumb View #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Rodrigora
wants to merge
86
commits into
react-native-elements:next
from
Rodrigora:passing-down-thumb-style-transform
Closed
uses thumbStyle.transform values in the thumb View #734
Rodrigora
wants to merge
86
commits into
react-native-elements:next
from
Rodrigora:passing-down-thumb-style-transform
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng/button_v1 Add beta folder to /example
…ng/button_v1 Refactor Button Component
…ng/input_v1 Refactor Input Component
…inear-gradient-button Add LinearGradient from Expo to Button
…ansparent RNE logo
…ogin-screen-3 New login screen 3
Collaborator
|
Hey @Rodrigora, will definitely need you to resubmit this PR. Previously we had messed up the branches, and stuff for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #712.
I added a snapshot test as this will change the Thumb style props.
Thanks guys