New login screen 3 #562
Merged
New login screen 3 #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monte9
reviewed
Aug 26, 2017
| @@ -1,45 +1,416 @@ | |||
| import React, { Component } from 'react'; | |||
Collaborator
There was a problem hiding this comment.
Just fyi, the above images are too big. 512 x 512. In the future compress them down to a smaller 128 x 128 & also provide a @2x & @3x for different phone sizes.
This might be useful to read: https://facebook.github.io/react-native/docs/images.html#static-image-resources
Monte9
reviewed
Aug 26, 2017
| return !fontLoaded | ||
| ? <Text> Loading... </Text> | ||
| : <ScrollView | ||
| scrollEnabled={false} |
Collaborator
There was a problem hiding this comment.
weird formatting. Also if a return is multi-line consider using () for readability
Monte9
reviewed
Aug 26, 2017
| <Button | ||
| text="Login here" | ||
| textStyle={styles.loginHereText} | ||
| containerStyle={{ flex: -1 }} |
Collaborator
There was a problem hiding this comment.
never seen a negative flex before. What is this doing?
Monte9
reviewed
Aug 26, 2017
| colors: ['#FF9800', '#F44336'], | ||
| start: [1, 0], | ||
| end: [0.2, 0], | ||
| }} |
Collaborator
|
@martinezguillaume solid implementation! 🔥 gj! Left a few comments. But looks good overall. Merging it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New login screen 🏌🏻
This pr has a dependency with this pr