@binoy14 @iRoachie thoughts on this? 🤔

Basically, here's what I had in mind while refactoring:

1. Simplify the named Props handles by Button.js (42 => 10) 😮
2. Make the code more legible and modularized ( Icon, for instance, needs to be passed in as an object, because the Button doesn't care about how/where you get your icon from)
3. Simple and easy to understand button layout with full flexibility by using containerStyle & style props
4. Implement common use cases as seen in various designs

Here's an example of what a button looks like:

<Button
  text="Add to Cart"
  underlayColor="rgba(80,117,196,1)"
  activeOpacity={0.4}
  textStyle={{fontWeight: 'bold', fontSize: 18}}
  buttonStyle={{backgroundColor: 'rgba(90, 154, 230, 1)', height: 40, width: 200, borderWidth: 0, borderColor: 'transparent', borderRadius: 20}}
  containerStyle={{marginVertical: 10}}
  icon={
    <Icon
      name='arrow-right'
      size={15}
      color='white'
    />
  }
  iconRight
  iconContainerStyle={{marginLeft: 5}}
/>

This will def break existing functionality, but I would rather have a cleaner and simpler API to work with for 1.0 than just patch and band-aid fixes with the current API.

Also here are some useful designs to implement in case anyone wants to play with the Button API.

• http://www.designyourway.net/blog/inspiration/menus-and-buttons-in-mobile-design-45-examples/
• https://www.behance.net/gallery/47612471/Travel-Leisure-Concept-Re-Design
• https://ionicframework.com/docs/components/#icon-buttons

p.s - if this get's approved, many more breaking changes and refactors to come. ;)

+1 for the icon change, hate passing an object for this.
also +1 for the style changes, current api can be confusing

Thanks for the feedback @nonotest!

This includes breaking changes but i think it is worth it. I really like the way you use textProps and loadingProps instead of exposing the entire API of those components through the Button component, I think this could be a good start point to simplify others ! 🔥
+1 for the icon change too, much more modular.

@nonotest @xavier-villelegier thanks for pitching in. I used this API myself to design buttons on the example app and I really like it. I think I have landed on a pretty stable API and it looks ready to be merged to me.

Also I have added a few todo items here.