Add Cancel Button Props Object for iOS #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps
This give a user the abilty to change the color of the text for iOS cancel button
…elements into add_cancel_button_color
Codecov Report
@@ Coverage Diff @@
## next #1159 +/- ##
=======================================
Coverage 63.03% 63.03%
=======================================
Files 30 30
Lines 533 533
Branches 84 84
=======================================
Hits 336 336
Misses 163 163
Partials 34 34
Continue to review full report at Codecov.
|
xavier-villelegier
requested changes
Apr 30, 2018
Collaborator
xavier-villelegier
left a comment
There was a problem hiding this comment.
Hey @M-Jas, thanks for contributing ! 🙏 As I reviewed in https://github.com/react-native-training/react-native-elements/pull/1126#pullrequestreview-113110918, to prevent many props to be added maybe just add cancelButtonProps and spread it into Button props.
Contributor
Author
|
@xavier-villelegier to confirm are you talking about something like the |
Collaborator
|
@M-Jas Yea exactly. It's just to avoid adding too many |
Users can now pass the normal React Native Button props to the cancel button.
Contributor
Author
|
@xavier-villelegier you got it. New PR should be up there shortly. Thanks for the feedback. |
xavier-villelegier
approved these changes
May 2, 2018
Collaborator
xavier-villelegier
left a comment
There was a problem hiding this comment.
Looks good to me, neat PR @M-Jas 💯
| Component = component; | ||
| } else if (onPress) { | ||
| Component = TouchableOpacity | ||
| Component = TouchableOpacity; |
Collaborator
There was a problem hiding this comment.
Just curious, is it your own prettier or the pre-commit hook which added these ?
Contributor
Author
There was a problem hiding this comment.
Must be the pre-commit, I didn't step into those file.
Contributor
Author
|
@xavier-villelegier Are we good on this or is there anything else I need to do? |
Monte9
pushed a commit
that referenced
this pull request
May 6, 2018
* Remove any occurence of `isRequired` #960 * fix(Title) Move disabled style (#1070) * fix(Title) Move disabled style * reorder styles * fix(types): ButtonGroup - Add selectedButtonStyle Replace selectedBackgroundColor with selectedButtonStyle * Run prettier on some stray files * Fix typo in listitem.md (#1078) * Fix typo in listitem.md 'checkbox' corrected to 'checkBox' * fix checkBox typo in versioned docs listitem.md * Allowed Badge to accept any component as the Container component (#1061) * Button group use platform touchable (#1087) * buttongroup platform specific touchable * move component prop logic defaultprops * Add WeChat color to SocialIcon (#1092) * (ListItem) Fix checkmark platform sizing (#1090) * Fix Overlay children typing * docs(Avatar): Add size props small, medium, large, xlarge * docs(ListItem): Change avatar to leftAvatar Add props descriptions to beta4 docs. Fixes #1069 * fix(Avatar): Re-add missing `imageProps` prop * Dismiss overlay by touching backdrop (#1094) * Dismiss Overlay by clicking outside of Overlay Modal * updated overlay docs * rename overlayBackgroundpress to onBackdropPress * updated overlay snapshot * fix overlay prop type * Add `onBackdropPress` to Overlay * Fix Icon style when using TouchableNativeFeedback (#1104) * add encasing view and update test * add encasing view and update test * Refactor Avatar Size props (#1098) * rewrite avatar size prop * updated docs * updated typescript definitions * updated docs, ts and size prop logic * fallback for icon dimension * @default docs * Add raised prop back to Button component (#1108) * Bump docusarus version * docs(website): Fix small bug in listitem docs header * docs(website): Set default version shown as 0.19.0 * docs(website): Replace main icon with svg * Add backdropPress example to docs (#1116) * Use v0.19.0 as default version (#1101) * Revert website default version (#1103) * Use v0.19.0 as default version * Revert "Use v0.19.0 as default version" This reverts commit 1caeefd. * Revert "Use v0.19.0 as default version" This reverts commit 1caeefd. * Add descriptions for ListItem props in v1.0.0-beta4 docs (#1118) * Remove weird duplicate in beta4 docs [ci skip] * button opacity layer border on button press (#1107) * Opacity layer borderRadius on Button press * borderRadius to containerStyle.borderRadius * containerStyle.borderRadius -> buttonStyle.borderRadadius😄 * docs(Card) Button icon needs to be a component (#1132) * Button icon needs to be a component * Use icon element instead of object for Card docs * ci(travis) Pin version of node Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps * Cleanup definitons [ci-skip] * Bounce Form elements (#1146) * Refactor and make uniform all SearchBars (#1135) * Remove useless flex * Refactor default SearchBar * Add renderIcon helper * Use helper for default SearchBar * Use renderIcon in Input * Add back input icons containers * Improve renderIcon helper * Remove useless import * Use renderIcon for iOS searchbar * Use renderIcon for Android searchbar * Update SearchBar and Input docs * Update this.clear call * Remove useless onCancel on default searchbar * Remove useless hasFocus on default props * Update tests * Fix tests with new props * Use renderNode + refactor nodeType * Fix typo + link to Input props * Use `false` instead of `null` [ci-skip] * docs(Input) Typo it should be labelStyle not labelString * docs(ListItem) onPress component should be TouchableOpacity (#1152) * Typo? It seems that a touchableopacity is added - not a touchablehighlight. shouldn't a touchablehighlight be used here? * https://medium.com/differential/better-cross-platform-react-native-components-cb8aadeba472 * https://stackoverflow.com/questions/39123357/when-to-use-touchablenativefeedback-touchablehighlight-or-touchableopacity thanks! * typo * Fix depth collision with Button and Overlay (#1113) * Update Overlay snapshots * Add Cancel Button Props Object for iOS (#1159) * docs(website): Set default version shown as 0.19.0 (#1156) * ci(travis) Pin version of node (#1158) Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps * enhancment(searchBar): add 'cancelButtonColor' to search bar component This give a user the abilty to change the color of the text for iOS cancel button * enhancement(searchBar) add 'cancelButtonProps' prop Users can now pass the normal React Native Button props to the cancel button. * Add iOS only to docs * Fix typo in input docs #1041 * Add FormValidationMessage in imports #1144 * (Button) Doc improvement: remove duplicate item (#1167) for 0.19.0 `Button` the `loading` item in props list is duplicate * Create helpers export * Cleanup SearchBar typings and docs (#1169) * (types) Cleanup searchbar definitions * docs(SearchBar): Add inputContainerStyle Closes #1123 * types (SearchBar) SearchBarAndroid should extend from SearchBarPlatform * Fix yarn merge conflict [ci-skip] * Apply renderNode for Button (#1170) * Update docs * Use renderNode helper * Update button icon type * Update types * docs(website): Add Troubleshooting section (#1171) * docs(website): Add Troubleshooting section * Add more complex steps for font issues * Bump version to v1.0.0-beta5 * Create new website version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#What does this PR do?