-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
v1.0.0-beta5 #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0-beta5 #1077
Conversation
* fix(Title) Move disabled style * reorder styles
Replace selectedBackgroundColor with selectedButtonStyle
|
Example app for the last commit (92d4e91): |
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
+ Coverage 55.82% 62.96% +7.14%
==========================================
Files 33 30 -3
Lines 609 532 -77
Branches 111 84 -27
==========================================
- Hits 340 335 -5
+ Misses 215 163 -52
+ Partials 54 34 -20
Continue to review full report at Codecov.
|
* Fix typo in listitem.md 'checkbox' corrected to 'checkBox' * fix checkBox typo in versioned docs listitem.md
* buttongroup platform specific touchable * move component prop logic defaultprops
small, medium, large, xlarge
Add props descriptions to beta4 docs. Fixes #1069
* Dismiss Overlay by clicking outside of Overlay Modal * updated overlay docs * rename overlayBackgroundpress to onBackdropPress * updated overlay snapshot * fix overlay prop type * Add `onBackdropPress` to Overlay
* add encasing view and update test * add encasing view and update test
* rewrite avatar size prop * updated docs * updated typescript definitions * updated docs, ts and size prop logic * fallback for icon dimension * @default docs
|
|
||
| add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component) | ||
|
|
||
| add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dups
|
|
||
| add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component) | ||
|
|
||
| add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iRoachie When git is drunk
* Opacity layer borderRadius on Button press * borderRadius to containerStyle.borderRadius * containerStyle.borderRadius -> buttonStyle.borderRadadius😄
* Button icon needs to be a component * Use icon element instead of object for Card docs
Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps
* Remove useless flex * Refactor default SearchBar * Add renderIcon helper * Use helper for default SearchBar * Use renderIcon in Input * Add back input icons containers * Improve renderIcon helper * Remove useless import * Use renderIcon for iOS searchbar * Use renderIcon for Android searchbar * Update SearchBar and Input docs * Update this.clear call * Remove useless onCancel on default searchbar * Remove useless hasFocus on default props * Update tests * Fix tests with new props * Use renderNode + refactor nodeType * Fix typo + link to Input props * Use `false` instead of `null` [ci-skip]
* Typo? It seems that a touchableopacity is added - not a touchablehighlight. shouldn't a touchablehighlight be used here? * https://medium.com/differential/better-cross-platform-react-native-components-cb8aadeba472 * https://stackoverflow.com/questions/39123357/when-to-use-touchablenativefeedback-touchablehighlight-or-touchableopacity thanks! * typo
* docs(website): Set default version shown as 0.19.0 (#1156) * ci(travis) Pin version of node (#1158) Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps * enhancment(searchBar): add 'cancelButtonColor' to search bar component This give a user the abilty to change the color of the text for iOS cancel button * enhancement(searchBar) add 'cancelButtonProps' prop Users can now pass the normal React Native Button props to the cancel button. * Add iOS only to docs
for 0.19.0 `Button` the `loading` item in props list is duplicate
* (types) Cleanup searchbar definitions * docs(SearchBar): Add inputContainerStyle Closes #1123 * types (SearchBar) SearchBarAndroid should extend from SearchBarPlatform
* Update docs * Use renderNode helper * Update button icon type * Update types
* docs(website): Add Troubleshooting section * Add more complex steps for font issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one step closer to v1 🔥
Issues and features for this release https://github.com/react-native-training/react-native-elements/milestone/4