Skip to content

Conversation

@iRoachie
Copy link
Collaborator

@iRoachie iRoachie commented Apr 6, 2018

xavier-villelegier and others added 3 commits April 3, 2018 12:09
* fix(Title) Move disabled style

* reorder styles
Replace selectedBackgroundColor with selectedButtonStyle
@react-native-elements-ci
Copy link
Collaborator

react-native-elements-ci commented Apr 6, 2018

@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #1077 into master will increase coverage by 7.14%.
The diff coverage is 60.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
+ Coverage   55.82%   62.96%   +7.14%     
==========================================
  Files          33       30       -3     
  Lines         609      532      -77     
  Branches      111       84      -27     
==========================================
- Hits          340      335       -5     
+ Misses        215      163      -52     
+ Partials       54       34      -20
Impacted Files Coverage Δ
src/card/Card.js 100% <ø> (ø) ⬆️
src/social/SocialIcon.js 91.66% <ø> (ø) ⬆️
src/tile/FeaturedTile.js 100% <ø> (ø) ⬆️
src/tile/Tile.js 100% <ø> (ø) ⬆️
src/slider/Slider.js 47.05% <ø> (ø) ⬆️
src/buttons/ButtonGroup.js 61.53% <ø> (-2.75%) ⬇️
src/buttons/Button.js 28.57% <0%> (-11.43%) ⬇️
src/input/Input.js 13.33% <0%> (-5.42%) ⬇️
src/overlay/Overlay.js 90.9% <0%> (-9.1%) ⬇️
src/list/ListItem.js 73.07% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e32b20...92d4e91. Read the comment docs.

iRoachie and others added 22 commits April 6, 2018 07:59
* Fix typo in listitem.md

'checkbox' corrected to 'checkBox'

* fix checkBox typo in versioned docs listitem.md
* buttongroup platform specific touchable

* move component prop logic defaultprops
small, medium, large, xlarge
Add props descriptions to beta4 docs. Fixes #1069
* Dismiss Overlay by clicking outside of Overlay Modal

* updated overlay docs

* rename overlayBackgroundpress to onBackdropPress

* updated overlay snapshot

* fix overlay prop type

* Add `onBackdropPress` to Overlay
* add encasing view and update test

* add encasing view and update test
* rewrite avatar size prop

* updated docs

* updated typescript definitions

* updated docs, ts and size prop logic

* fallback for icon dimension

* @default docs
* Use v0.19.0 as default version

* Revert "Use v0.19.0 as default version"

This reverts commit 1caeefd.

* Revert "Use v0.19.0 as default version"

This reverts commit 1caeefd.

add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component)

add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dups


add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component)

add a checkbox on the right side (object with the props of the React Native Elements `CheckBox` component)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iRoachie When git is drunk

xavier-villelegier and others added 16 commits April 15, 2018 15:58
* Opacity layer borderRadius on Button press

* borderRadius to containerStyle.borderRadius

* containerStyle.borderRadius  -> buttonStyle.borderRadadius😄
* Button icon needs to be a component

* Use icon element instead of object for Card docs
Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps
* Remove useless flex

* Refactor default SearchBar

* Add renderIcon helper

* Use helper for default SearchBar

* Use renderIcon in Input

* Add back input icons containers

* Improve renderIcon helper

* Remove useless import

* Use renderIcon for iOS searchbar

* Use renderIcon for Android searchbar

* Update SearchBar and Input docs

* Update this.clear call

* Remove useless onCancel on default searchbar

* Remove useless hasFocus on default props

* Update tests

* Fix tests with new props

* Use renderNode + refactor nodeType

* Fix typo + link to Input props

* Use `false` instead of `null` [ci-skip]
* docs(website): Set default version shown as 0.19.0 (#1156)

* ci(travis) Pin version of node (#1158)

Node 10 currently breaks builds cause of missing whitelist console in react native jest setup. jestjs/jest#2567 (comment) Pinning node version until react-native/jest bumps

* enhancment(searchBar): add 'cancelButtonColor' to search bar component

This give a user the abilty to change the color of the text for iOS cancel button

* enhancement(searchBar) add 'cancelButtonProps' prop

Users can now pass the normal React Native Button props to the cancel button.

* Add iOS only to docs
for 0.19.0 `Button`
the `loading` item in props list is duplicate
iRoachie and others added 7 commits May 6, 2018 14:53
* (types) Cleanup searchbar definitions

* docs(SearchBar): Add inputContainerStyle

Closes #1123

* types (SearchBar) SearchBarAndroid should extend from SearchBarPlatform
* Update docs

* Use renderNode helper

* Update button icon type

* Update types
* docs(website): Add Troubleshooting section

* Add more complex steps for font issues
Copy link
Collaborator

@Monte9 Monte9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: one step closer to v1 🔥

@Monte9 Monte9 merged commit d4da856 into master May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.