This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Groom 0.62 Changelog#176
Merged
rickhanlonii merged 4 commits intochore/062-changelog-newfrom Mar 24, 2020
Merged
Conversation
Contributor
Author
|
After this we still need to:
|
Contributor
Author
|
@TheSavior I also removed anything that was changing flow types. This is debatable - if we're going to include them though I think we should move them all to their own sections. If you can about flow types, you'll want to read them all in one place. |
alloy
approved these changes
Mar 21, 2020
Member
alloy
left a comment
There was a problem hiding this comment.
Minor stuff, otherwise cleaning up nicely 👌
motiz88
reviewed
Mar 21, 2020
| - Remove framesToPop from bridge ([a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88)) | ||
| - Remove TimePickerAndroid from React Native ([dbf070c51e](https://github.com/facebook/react-native/commit/dbf070c51ecd14127a8317faa75cb661697b5a6b) by [@cpojer](https://github.com/cpojer)) | ||
| - Remove scrollWithoutAnimationTo from ScrollView ([c7e89909da](https://github.com/facebook/react-native/commit/c7e89909da70ac5290f9971080eb897567db3e43) by [@TheSavior](https://github.com/TheSavior)) | ||
| - Remove support for `framesToPop` ([8bc02fdd52](https://github.com/facebook/react-native/commit/8bc02fdd52124d0a24d96e4a61d7688328ef1660) [cf4d45ec2b](https://github.com/facebook/react-native/commit/cf4d45ec2bcd301be7793d5840de21ec7d02275b) [a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88)) |
There was a problem hiding this comment.
Commented on the other PR. I don't think this is necessarily a breaking change.
Contributor
Author
There was a problem hiding this comment.
@motiz88 could it be breaking for error reporters e.g. Sentry?
There was a problem hiding this comment.
It's an observable change in behaviour, and if they rely on it in a very particular way, then it could conceivably require them to fix something on their end. So in that sense: Yes.
But it's more "this implementation detail changed, heads up if you've come to rely on it" which might not be the same thing as "this documented public API has gone away". Maybe I'm splitting hairs though. I also get that it's probably better to err on the side of caution.
elicwhite
approved these changes
Mar 21, 2020
Contributor
|
Really good cleanup here 👍 |
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
kelset
added a commit
that referenced
this pull request
Mar 26, 2020
* changelog for 0.62 up to rc3 * [CHANGELOG] Update after fixing commit resolving #169 * [CHANGELOG] Update for v0.62.0-rc.4 * [CHANGELOG] Sort unknowns by author * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * small tweaks to remove a couple warnings * a few more typos fixes * feedback * remove empty section * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * last feedback from Jeremy * couple other tweaks * better fix for it * adding a draft for the intro * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * changelog: move around some misplaced commits (#174) * add more details about CLI upgrade * Address unknown changelog entries (#175) * Address unknown changelog entries * Updates from feedback * Add andorid changes back * Groom 0.62 Changelog (#176) * Groom 0.62 Changelog * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Apply suggestions from code review Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Add Flipper, feedback from reviews Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * changelog: removed duplicates and fixed inconsistent formatting (#177) * Update 0.62 description (#178) * Update 0.62 description * Apply suggestions from code review Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Fix typo Co-Authored-By: Core <aukwat@gmail.com> * Remove a known issue * Update CHANGELOG.md Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Core <aukwat@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR grooms the 0.62 changelog, removing internal items and renaming/rewording others.