Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

changelog: move around some misplaced commits#174

Merged
kelset merged 1 commit intoreact-native-community:chore/062-changelog-newfrom
jeremy-deutsch:chore/062-changelog-new
Mar 20, 2020
Merged

changelog: move around some misplaced commits#174
kelset merged 1 commit intoreact-native-community:chore/062-changelog-newfrom
jeremy-deutsch:chore/062-changelog-new

Conversation

@jeremy-deutsch
Copy link
Copy Markdown
Contributor

@jeremy-deutsch jeremy-deutsch commented Mar 19, 2020

This MR just moves around some changelog items that I think were in the wrong section. Let me know if any of the moves don't seem right!

A couple notes:

  • There's still a lot of noise in some of the sections, pending FB doing their changelog sweep.
  • I tried not to touch the same commits that @rickhanlonii and the FB crew might touch. That means that I didn't mark anything as to-remove, or touch any unknowns that had a known committer, since FB might want to move those.
  • The CLI version bump being in "breaking" specifically comes from a single incident where changes to the CLI (that didn't make it into the changelog) broke one of my team's build scripts. (This was when the CLI wasn't in its own repo.)

I'll probably take another look after FB makes their changes, depending on the scope of those changes and what they address.

@jeremy-deutsch
Copy link
Copy Markdown
Contributor Author

@alloy @kelset

- Animated: Remove `defaultProps` Parameter ([a70987cee2](https://github.com/facebook/react-native/commit/a70987cee24bcd027b9c4a5aa85dfd6a1aab74b3) by [@yungsters](https://github.com/yungsters))
- RN: Delete `TextInput.selectionState` Prop ([2becdfd404](https://github.com/facebook/react-native/commit/2becdfd4041f7f28138ba3a61c03e17c06dc2e50) by [@yungsters](https://github.com/yungsters))
- Remove scrollWithoutAnimationTo from ScrollView ([c7e89909da](https://github.com/facebook/react-native/commit/c7e89909da70ac5290f9971080eb897567db3e43) by [@TheSavior](https://github.com/TheSavior))
- Bump CLI to ^4.2.x ([be5088401f](https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064) by [@alloy](https://github.com/alloy))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremy-deutsch @grabbou Would be good if this expanded a little on the actual change so people can more easily understand how it affects them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we could just add a couple words and link them them to https://callstack.com/blog/react-native-cli-3-1-0-and-4-0-0-whats-new/ ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to address this [here](add more details about CLI upgrade) - wanted to merge this asap so that Ricky can work against the base PR in #175

@kelset kelset added the enhancement New feature or request label Mar 20, 2020
@kelset kelset merged commit 58dd38e into react-native-community:chore/062-changelog-new Mar 20, 2020
kelset added a commit that referenced this pull request Mar 26, 2020
* changelog for 0.62 up to rc3

* [CHANGELOG] Update after fixing commit resolving

#169

* [CHANGELOG] Update for v0.62.0-rc.4

* [CHANGELOG] Sort unknowns by author

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* small tweaks to remove a couple warnings

* a few more typos fixes

* feedback

* remove empty section

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* last feedback from Jeremy

* couple other tweaks

* better fix for it

* adding a draft for the intro

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: move around some misplaced commits (#174)

* add more details about CLI upgrade

* Address unknown changelog entries (#175)

* Address unknown changelog entries

* Updates from feedback

* Add andorid changes back

* Groom 0.62 Changelog (#176)

* Groom 0.62 Changelog

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Add Flipper, feedback from reviews

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: removed duplicates and fixed inconsistent formatting (#177)

* Update 0.62 description (#178)

* Update 0.62 description

* Apply suggestions from code review

Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Fix typo

Co-Authored-By: Core <aukwat@gmail.com>

* Remove a known issue

* Update CHANGELOG.md

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com>
Co-authored-by: Ricky <rickhanlonii@gmail.com>
Co-authored-by: Core <aukwat@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants