Skip to content

[Fizz] Use RequestInstance constructor for resuming#30947

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:resumerequestinstance
Sep 11, 2024
Merged

[Fizz] Use RequestInstance constructor for resuming#30947
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:resumerequestinstance

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

We added enough fields to need a constructor instead of inline object in V8.

We didn't update the resumeRequest path though so it wasn't using the constructor and had a different hidden class.

@sebmarkbage sebmarkbage requested a review from gnoff September 11, 2024 15:09
@vercel

vercel Bot commented Sep 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:11pm

@react-sizebot

Copy link
Copy Markdown

Comparing: 344bc8128bc8f135e3fe6bb3449580d216ec7639...d9ae223f1b643bece96d6859da4f3351bfe446d2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 505.22 kB 505.22 kB = 90.29 kB 90.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 600.88 kB 600.88 kB = 106.29 kB 106.28 kB
facebook-www/ReactDOM-prod.modern.js = 577.17 kB 577.17 kB = 102.43 kB 102.43 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 245.69 kB 245.18 kB = 43.94 kB 43.78 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 250.21 kB 249.58 kB = 44.80 kB 44.70 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 244.58 kB 243.95 kB = 42.81 kB 42.71 kB
oss-experimental/react-server/cjs/react-server.development.js = 177.42 kB 176.71 kB = 31.49 kB 31.34 kB
oss-stable-rc/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-stable/react-server/cjs/react-server.development.js = 156.87 kB 156.17 kB = 28.71 kB 28.56 kB
oss-experimental/react-server/cjs/react-server.production.js = 122.44 kB 121.76 kB = 21.73 kB 21.58 kB
oss-stable-rc/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB
oss-stable/react-server/cjs/react-server.production.js = 109.09 kB 108.42 kB = 19.89 kB 19.75 kB

Generated by 🚫 dangerJS against 0e864ca

@sebmarkbage sebmarkbage merged commit 1bb0563 into react:main Sep 11, 2024
github-actions Bot pushed a commit that referenced this pull request Sep 11, 2024
We added enough fields to need a constructor instead of inline object in
V8.

We didn't update the resumeRequest path though so it wasn't using the
constructor and had a different hidden class.

DiffTrain build for [1bb0563](1bb0563)
gnoff pushed a commit to vercel/next.js that referenced this pull request Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`**

[diff
react/react@7771d3a7...94e652d5](react/react@7771d3a...94e652d)

<details>
<summary>React upstream changes</summary>

- react/react#30952
- react/react#30950
- react/react#30946
- react/react#30934
- react/react#30947
- react/react#30945
- react/react#30938
- react/react#30936
- react/react#30879
- react/react#30888
- react/react#30931
- react/react#30930
- react/react#30832
- react/react#30929
- react/react#30926
- react/react#30925
- react/react#30905
- react/react#30900
- react/react#30910
- react/react#30906
- react/react#30899
- react/react#30919
- react/react#30708
- react/react#30907
- react/react#30897
- react/react#30896
- react/react#30895
- react/react#30887
- react/react#30889
- react/react#30893
- react/react#30892
- react/react#30891
- react/react#30882
- react/react#30881
- react/react#30870
- react/react#30849
- react/react#30878
- react/react#30865
- react/react#30869
- react/react#30875
- react/react#30800
- react/react#30762
- react/react#30831
- react/react#30866
- react/react#30853
- react/react#30850
- react/react#30847
- react/react#30842
- react/react#30837
- react/react#30848
- react/react#30844
- react/react#30839
- react/react#30802
- react/react#30841
- react/react#30827
- react/react#30826
- react/react#30825
- react/react#30824
- react/react#30840
- react/react#30838
- react/react#30836
- react/react#30819
- react/react#30816
- react/react#30814
- react/react#30813
- react/react#30812
- react/react#30811

</details>

---------

Co-authored-by: vercel-release-bot <infra+release@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants