[Flight] Unwrap lazy before reading the value#30938
Merged
Merged
Conversation
This is important if the lazy is at the root of the chunk.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: a5a7f1063e6f190c64c779b2aa54d28fb7b92cfb...80f40b1ff329a56f32149dc94fb61123b301ef65 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
approved these changes
Sep 10, 2024
gnoff
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 12, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff react/react@7771d3a7...94e652d5](react/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - react/react#30952 - react/react#30950 - react/react#30946 - react/react#30934 - react/react#30947 - react/react#30945 - react/react#30938 - react/react#30936 - react/react#30879 - react/react#30888 - react/react#30931 - react/react#30930 - react/react#30832 - react/react#30929 - react/react#30926 - react/react#30925 - react/react#30905 - react/react#30900 - react/react#30910 - react/react#30906 - react/react#30899 - react/react#30919 - react/react#30708 - react/react#30907 - react/react#30897 - react/react#30896 - react/react#30895 - react/react#30887 - react/react#30889 - react/react#30893 - react/react#30892 - react/react#30891 - react/react#30882 - react/react#30881 - react/react#30870 - react/react#30849 - react/react#30878 - react/react#30865 - react/react#30869 - react/react#30875 - react/react#30800 - react/react#30762 - react/react#30831 - react/react#30866 - react/react#30853 - react/react#30850 - react/react#30847 - react/react#30842 - react/react#30837 - react/react#30848 - react/react#30844 - react/react#30839 - react/react#30802 - react/react#30841 - react/react#30827 - react/react#30826 - react/react#30825 - react/react#30824 - react/react#30840 - react/react#30838 - react/react#30836 - react/react#30819 - react/react#30816 - react/react#30814 - react/react#30813 - react/react#30812 - react/react#30811 </details> --------- Co-authored-by: vercel-release-bot <infra+release@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is important if the lazy is at the root of the chunk. I don't have a unit test for it but @gnoff has a repro.
It also shouldn't unwrap the last value since that's the one we're referencing.
This was already done correctly by @unstubbable in waitForReference so this just aligns with that.