Ensure react-dom/client is built in Codesandbox preview builds#30757
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 92d26c8e93a88ca41338d3509b4324ad19a89c1e...36dd945f195047618d4f4d7f16ad7f2756fb46de Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
kassens
approved these changes
Aug 20, 2024
eps1lon
added a commit
to vercel/next.js
that referenced
this pull request
Aug 23, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-1eaccd82-20240816` to `19.0.0-rc-eb3ad065-20240822`** No changes required in Next.js it seems. [diff react/react@1eaccd82...eb3ad065](react/react@1eaccd8...eb3ad06) <details> <summary>React upstream changes</summary> - react/react#30761 - react/react#30779 - react/react#30775 - react/react#30770 - react/react#30756 - react/react#30755 - react/react#30768 - react/react#30760 - react/react#30732 - react/react#30757 - react/react#30750 - react/react#30751 - react/react#30753 - react/react#30740 - react/react#30748 - react/react#30746 - react/react#30747 - react/react#30731 - react/react#30725 - react/react#30741 - react/react#30730 - react/react#30726 - react/react#30717 - react/react#30729 - react/react#30721 - react/react#30720 - react/react#30705 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-dom/clientwasn't usable in Codesandbox preview builds because we never built it. This used to work because the client APIs used to be exported fromreact-dom/indexbut now aren't so we need to explicitly list the entrypoint.How did you test this change?