Skip to content

[Flight] Rename Chunk constructor to ReactPromise#30747

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:renamechunk
Aug 19, 2024
Merged

[Flight] Rename Chunk constructor to ReactPromise#30747
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:renamechunk

Conversation

@sebmarkbage

@sebmarkbage sebmarkbage commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

When printing these in DevTools they show up as the name of the constructor so then you pass a Promise to the client it logs as "Chunk" which is confusing.

Ideally we'd probably just name this Promise but 1) there's a slight difference in the .then method atm 2) it's a bit tricky to name a variable and get it from the global in the same scope. Closure compiler doesn't let us just name a function because it removes it and just uses the variable name.

@sebmarkbage sebmarkbage requested a review from gnoff August 19, 2024 17:37
@vercel

vercel Bot commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 5:42pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Aug 19, 2024
@sebmarkbage sebmarkbage mentioned this pull request Aug 19, 2024
Merged
@sebmarkbage
Rename Chunk constructor to ReactPromise
9067f28 
When printing these in DevTools they show up as the name of the constructor
so then you pass a Promise to the client it logs as "Chunk" which is confusing.

Ideally we'd probably just name this Promise but 1) there's a slight difference
in the .then method atm 2) it's a bit tricky to name a variable.
@react-sizebot

react-sizebot commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Comparing: 6ebfd5b0829c3e7a977ef4d9a0bd96436c681251...50cc9464fb3d86915b92c7ce1e433dd874dc90aa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.59% 87.52 kB 88.04 kB +0.48% 16.53 kB 16.61 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.59% 89.12 kB 89.65 kB +0.37% 16.37 kB 16.43 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.58% 89.37 kB 89.89 kB +0.40% 16.93 kB 17.00 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.58% 89.83 kB 90.34 kB +0.40% 17.04 kB 17.11 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.56% 92.47 kB 92.99 kB +0.39% 17.82 kB 17.89 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.55% 47.27 kB 47.53 kB +0.30% 9.64 kB 9.67 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.55% 93.88 kB 94.40 kB +0.47% 18.12 kB 18.20 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.55% 94.69 kB 95.21 kB +0.44% 18.29 kB 18.37 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.55% 46.76 kB 47.02 kB +0.29% 9.56 kB 9.59 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.55% 46.76 kB 47.02 kB +0.29% 9.56 kB 9.59 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.55% 46.76 kB 47.02 kB +0.29% 9.56 kB 9.59 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.54% 96.06 kB 96.57 kB +0.42% 18.53 kB 18.61 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.54% 96.07 kB 96.59 kB +0.43% 18.51 kB 18.59 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.54% 48.87 kB 49.14 kB +0.28% 10.01 kB 10.03 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.54% 97.86 kB 98.39 kB +0.50% 18.63 kB 18.73 kB
oss-experimental/react-client/cjs/react-client-flight.production.js +0.53% 53.13 kB 53.41 kB +0.24% 9.81 kB 9.83 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.53% 49.21 kB 49.47 kB +0.28% 10.10 kB 10.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.53% 98.66 kB 99.18 kB +0.50% 18.81 kB 18.90 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.53% 48.37 kB 48.63 kB +0.32% 9.93 kB 9.97 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.53% 48.37 kB 48.63 kB +0.32% 9.93 kB 9.97 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.53% 48.37 kB 48.63 kB +0.32% 9.93 kB 9.97 kB
oss-stable-rc/react-client/cjs/react-client-flight.production.js +0.53% 52.73 kB 53.00 kB +0.26% 9.76 kB 9.78 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js +0.53% 52.73 kB 53.00 kB +0.26% 9.76 kB 9.78 kB
oss-stable/react-client/cjs/react-client-flight.production.js +0.53% 52.73 kB 53.00 kB +0.26% 9.76 kB 9.78 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.52% 48.71 kB 48.96 kB +0.31% 10.02 kB 10.06 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.52% 48.71 kB 48.96 kB +0.31% 10.02 kB 10.06 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.52% 48.71 kB 48.96 kB +0.31% 10.02 kB 10.06 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.51% 51.52 kB 51.79 kB +0.25% 10.64 kB 10.67 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.50% 51.02 kB 51.28 kB +0.25% 10.58 kB 10.60 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.50% 51.02 kB 51.28 kB +0.25% 10.58 kB 10.60 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.50% 51.02 kB 51.28 kB +0.25% 10.58 kB 10.60 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.50% 52.78 kB 53.04 kB +0.24% 10.92 kB 10.95 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.49% 53.48 kB 53.74 kB +0.24% 11.08 kB 11.10 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.49% 52.28 kB 52.53 kB +0.22% 10.86 kB 10.88 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.49% 52.28 kB 52.53 kB +0.22% 10.86 kB 10.88 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js +0.49% 52.28 kB 52.53 kB +0.22% 10.86 kB 10.88 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.48% 52.98 kB 53.23 kB +0.23% 11.01 kB 11.04 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.48% 52.98 kB 53.23 kB +0.23% 11.01 kB 11.04 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.48% 52.98 kB 53.23 kB +0.23% 11.01 kB 11.04 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.48% 54.62 kB 54.88 kB +0.23% 11.30 kB 11.33 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.48% 54.63 kB 54.90 kB +0.23% 11.29 kB 11.32 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.47% 54.12 kB 54.38 kB +0.23% 11.24 kB 11.27 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.47% 54.12 kB 54.38 kB +0.23% 11.24 kB 11.27 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.47% 54.12 kB 54.38 kB +0.23% 11.24 kB 11.27 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.47% 54.13 kB 54.39 kB +0.23% 11.23 kB 11.25 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.47% 54.13 kB 54.39 kB +0.23% 11.23 kB 11.25 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.47% 54.13 kB 54.39 kB +0.23% 11.23 kB 11.25 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.46% 56.35 kB 56.62 kB +0.24% 11.43 kB 11.46 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.46% 57.04 kB 57.30 kB +0.24% 11.59 kB 11.62 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.46% 55.87 kB 56.13 kB +0.20% 11.37 kB 11.39 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.46% 55.87 kB 56.13 kB +0.20% 11.37 kB 11.39 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.46% 55.87 kB 56.13 kB +0.20% 11.37 kB 11.39 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.45% 56.56 kB 56.81 kB +0.22% 11.53 kB 11.55 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.45% 56.56 kB 56.81 kB +0.22% 11.53 kB 11.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.45% 56.56 kB 56.81 kB +0.22% 11.53 kB 11.55 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.44% 79.62 kB 79.97 kB +0.23% 14.98 kB 15.02 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.44% 79.62 kB 79.97 kB +0.23% 14.98 kB 15.02 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.44% 79.62 kB 79.97 kB +0.23% 14.98 kB 15.02 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js +0.44% 81.34 kB 81.70 kB +0.27% 14.79 kB 14.83 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.44% 81.34 kB 81.70 kB +0.27% 14.79 kB 14.83 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.44% 81.34 kB 81.70 kB +0.27% 14.79 kB 14.83 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.43% 81.62 kB 81.98 kB +0.23% 15.37 kB 15.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.43% 81.62 kB 81.98 kB +0.23% 15.37 kB 15.41 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.43% 81.62 kB 81.98 kB +0.23% 15.37 kB 15.41 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.43% 82.08 kB 82.43 kB +0.23% 15.49 kB 15.52 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.43% 82.08 kB 82.43 kB +0.23% 15.49 kB 15.52 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.43% 82.08 kB 82.43 kB +0.23% 15.49 kB 15.52 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.42% 84.72 kB 85.07 kB +0.27% 16.22 kB 16.27 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.42% 84.72 kB 85.07 kB +0.27% 16.22 kB 16.27 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.42% 84.72 kB 85.07 kB +0.27% 16.22 kB 16.27 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.41% 86.13 kB 86.49 kB +0.25% 16.53 kB 16.57 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.41% 86.13 kB 86.49 kB +0.25% 16.53 kB 16.57 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.41% 86.13 kB 86.49 kB +0.25% 16.53 kB 16.57 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.41% 86.94 kB 87.30 kB +0.22% 16.70 kB 16.74 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.41% 86.94 kB 87.30 kB +0.22% 16.70 kB 16.74 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.41% 86.94 kB 87.30 kB +0.22% 16.70 kB 16.74 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.40% 88.31 kB 88.66 kB +0.23% 16.99 kB 17.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.40% 88.31 kB 88.66 kB +0.23% 16.99 kB 17.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.40% 88.31 kB 88.66 kB +0.23% 16.99 kB 17.03 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.40% 88.32 kB 88.68 kB +0.22% 16.97 kB 17.01 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.40% 88.32 kB 88.68 kB +0.22% 16.97 kB 17.01 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.40% 88.32 kB 88.68 kB +0.22% 16.97 kB 17.01 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.40% 89.99 kB 90.35 kB +0.29% 17.01 kB 17.06 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.40% 89.99 kB 90.35 kB +0.29% 17.01 kB 17.06 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.40% 89.99 kB 90.35 kB +0.29% 17.01 kB 17.06 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.40% 90.78 kB 91.14 kB +0.27% 17.19 kB 17.24 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.40% 90.78 kB 91.14 kB +0.27% 17.19 kB 17.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.40% 90.78 kB 91.14 kB +0.27% 17.19 kB 17.24 kB

Generated by 🚫 dangerJS against 9067f28

@sebmarkbage sebmarkbage merged commit 591adfa into react:main Aug 19, 2024
@eps1lon eps1lon mentioned this pull request Aug 22, 2024
Merged
eps1lon added a commit to vercel/next.js that referenced this pull request Aug 23, 2024
@eps1lon
Update React from 1eaccd82-20240816 to eb3ad065-20240822 (#69196)
6c09bd9 
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-1eaccd82-20240816` to `19.0.0-rc-eb3ad065-20240822`**

No changes required in Next.js it seems.

[diff
react/react@1eaccd82...eb3ad065](react/react@1eaccd8...eb3ad06)
<details>
<summary>React upstream changes</summary>

- react/react#30761
- react/react#30779
- react/react#30775
- react/react#30770
- react/react#30756
- react/react#30755
- react/react#30768
- react/react#30760
- react/react#30732
- react/react#30757
- react/react#30750
- react/react#30751
- react/react#30753
- react/react#30740
- react/react#30748
- react/react#30746
- react/react#30747
- react/react#30731
- react/react#30725
- react/react#30741
- react/react#30730
- react/react#30726
- react/react#30717
- react/react#30729
- react/react#30721
- react/react#30720
- react/react#30705

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gnoff gnoff gnoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage @react-sizebot @gnoff @facebook-github-bot