Skip to content

Update error codes on docs branch#10622

Merged
flarnie merged 1 commit into
react:gh-pagesfrom
flarnie:gh-pages
Sep 6, 2017
Merged

Update error codes on docs branch#10622
flarnie merged 1 commit into
react:gh-pagesfrom
flarnie:gh-pages

Conversation

@flarnie

@flarnie flarnie commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

what is the change?:
This just updated the error codes on the docs.

For my future self, recording the steps it took to get here:

why make this change?:
Even though this is just an RC, and not a final major release, we still
want the docs to be as up-to-date as possible.

test plan:
Run the docs locally and make sure things work.
screen shot 2017-09-06 at 10 40 57 am

issue:
#8854

**what is the change?:**
This just updated the error codes on the docs.

For my future self, recording the steps it took to get here:
- On master, run `npm run build -- --extract-errors`
- Create a commit with those changes, and open a PR
  (react#10619)
- Cherry-pick that commit onto 15-stable, and open a PR
  (react#10621)
- Update the error codes on the `gh-pages branch` by doing the
  following based on docs
  (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact):
  - Set up a sister directory to `react` with `gh-pages` checked out,
    and call it `react-gh-pages`
  - In your `react` repo, with `15-stable` checked out and the
    error-codes update cherry-picked, run:
    `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release`
  - `cd ../react-gh-pages` and check in those changes, create a
    commit/PR
  - Manually test running the docs

**why make this change?:**
Even though this is just an RC, and not a final major release, we still
want the docs to be as up-to-date as possible.

**test plan:**
Run the docs locally and make sure things work.
(Flarnie will insert screenshots.)

**issue:**
react#8854
@flarnie flarnie changed the title Update error codes Update error codes on docs branch Sep 6, 2017

@gaearon gaearon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. Any changes to gh-pages will be overriden on next CI build.

@sophiebits sophiebits left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually hurt so I'll approve, but Circle should build gh-pages automatically.

@sophiebits

Copy link
Copy Markdown
Collaborator

(As long as this is landed with #10621.)

@gaearon

gaearon commented Sep 6, 2017

Copy link
Copy Markdown
Collaborator

Ah, I missed that one, thanks for explaining!

@flarnie

flarnie commented Sep 6, 2017

Copy link
Copy Markdown
Contributor Author

Ah - in the past we had manually committed to this branch in order to update the docs faster than CI might run, but in this case there is no real rush. We can wait for #10621 to land.

@flarnie flarnie closed this Sep 6, 2017
@flarnie

flarnie commented Sep 6, 2017

Copy link
Copy Markdown
Contributor Author

:} Well if you don't mind, I'll land them like dominoes falling:
#10619 -> #10621 -> this one

mini_domino

@flarnie flarnie reopened this Sep 6, 2017
@flarnie

flarnie commented Sep 6, 2017

Copy link
Copy Markdown
Contributor Author

Looks like CI failing here is normal? https://circleci.com/gh/facebook/react/tree/gh-pages

@sophiebits

Copy link
Copy Markdown
Collaborator

On my phone, but the 15-stable branch is the one to look at.

And yes, fine landing this as long as it's just being built from the latest code in 15-stable.

@sophiebits

Copy link
Copy Markdown
Collaborator

Oh, yes, that seems fine.

@flarnie flarnie merged commit cbf4858 into react:gh-pages Sep 6, 2017
@flarnie flarnie mentioned this pull request Sep 6, 2017
55 tasks
dilberx pushed a commit to dilberx/react that referenced this pull request Apr 15, 2026
**what is the change?:**
This just updated the error codes on the docs.

For my future self, recording the steps it took to get here:
- On master, run `npm run build -- --extract-errors`
- Create a commit with those changes, and open a PR
  (react#10619)
- Cherry-pick that commit onto 15-stable, and open a PR
  (react#10621)
- Update the error codes on the `gh-pages branch` by doing the
  following based on docs
  (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact):
  - Set up a sister directory to `react` with `gh-pages` checked out,
    and call it `react-gh-pages`
  - In your `react` repo, with `15-stable` checked out and the
    error-codes update cherry-picked, run:
    `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release`
  - `cd ../react-gh-pages` and check in those changes, create a
    commit/PR
  - Manually test running the docs

**why make this change?:**
Even though this is just an RC, and not a final major release, we still
want the docs to be as up-to-date as possible.

**test plan:**
Run the docs locally and make sure things work.
(Flarnie will insert screenshots.)

**issue:**
react#8854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants