Update error codes and results.json#10619
Merged
Merged
Conversation
Contributor
|
Is this what we want to do right before an RC? (Update the Yarn lockfile, that is?) Should we maybe only update our deps (not dev deps): "fbjs": "^0.8.9",
"loose-envify": "^1.1.0",
"object-assign": "^4.1.0",
"prop-types": "^15.5.6" |
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Sep 6, 2017
**what is the change?:** This just updated the error codes on the docs. For my future self, recording the steps it took to get here: - On master, run `npm run build -- --extract-errors` - Create a commit with those changes, and open a PR (react#10619) - Cherry-pick that commit onto 15-stable, and open a PR (react#10621) - Update the error codes on the `gh-pages branch` by doing the following based on docs (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact): - Set up a sister directory to `react` with `gh-pages` checked out, and call it `react-gh-pages` - In your `react` repo, with `15-stable` checked out and the error-codes update cherry-picked, run: `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release` - `cd ../react-gh-pages` and check in those changes, create a commit/PR - Manually test running the docs **why make this change?:** Even though this is just an RC, and not a final major release, we still want the docs to be as up-to-date as possible. **test plan:** Run the docs locally and make sure things work. (Flarnie will insert screenshots.) **issue:** react#8854
**what is the change?:** Ran the build after updating Yarn lockfile and recorded latest build size results. **why make this change?:** Let's get an idea of bundle size at this point, when we are preparing the 16.0 RC. **test plan:** NA **issue:** react#8854
Contributor
Author
|
I'm not sure about how we want the Yarn lockfile updated - it's in the docs for doing releases, but we should decide what makes sense. I'll remove that commit from this PR so we can get the error code and bundle size changes in faster. |
13b79bb to
4495c0f
Compare
sophiebits
approved these changes
Sep 6, 2017
Collaborator
Collaborator
|
Agree. loose-envify doesn't matter either way for our built bundles but upgrading those four makes sense to me. |
Collaborator
|
|
gaearon
approved these changes
Sep 6, 2017
flarnie
added a commit
that referenced
this pull request
Sep 6, 2017
**what is the change?:** This just updated the error codes on the docs. For my future self, recording the steps it took to get here: - On master, run `npm run build -- --extract-errors` - Create a commit with those changes, and open a PR (#10619) - Cherry-pick that commit onto 15-stable, and open a PR (#10621) - Update the error codes on the `gh-pages branch` by doing the following based on docs (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact): - Set up a sister directory to `react` with `gh-pages` checked out, and call it `react-gh-pages` - In your `react` repo, with `15-stable` checked out and the error-codes update cherry-picked, run: `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release` - `cd ../react-gh-pages` and check in those changes, create a commit/PR - Manually test running the docs **why make this change?:** Even though this is just an RC, and not a final major release, we still want the docs to be as up-to-date as possible. **test plan:** Run the docs locally and make sure things work. (Flarnie will insert screenshots.) **issue:** #8854
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Sep 8, 2017
* Update results.json **what is the change?:** Ran the build after updating Yarn lockfile and recorded latest build size results. **why make this change?:** Let's get an idea of bundle size at this point, when we are preparing the 16.0 RC. **test plan:** NA **issue:** react#8854 * Update error codes https://github.com/facebook/react/tree/master/scripts/release-manager#update-the-error-codes
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
**what is the change?:** This just updated the error codes on the docs. For my future self, recording the steps it took to get here: - On master, run `npm run build -- --extract-errors` - Create a commit with those changes, and open a PR (react/react#10619) - Cherry-pick that commit onto 15-stable, and open a PR (react/react#10621) - Update the error codes on the `gh-pages branch` by doing the following based on docs (https://github.com/facebook/react/tree/master/docs#updating-facebookgithubioreact): - Set up a sister directory to `react` with `gh-pages` checked out, and call it `react-gh-pages` - In your `react` repo, with `15-stable` checked out and the error-codes update cherry-picked, run: `cd docs && bundle rake exec && bundle exec rake fetch_remotes && bundle exec rake release` - `cd ../react-gh-pages` and check in those changes, create a commit/PR - Manually test running the docs **why make this change?:** Even though this is just an RC, and not a final major release, we still want the docs to be as up-to-date as possible. **test plan:** Run the docs locally and make sure things work. (Flarnie will insert screenshots.) **issue:** react/react#8854
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
georgespeelman02-create
pushed a commit
to georgespeelman02-create/react
that referenced
this pull request
Jun 4, 2026
…tted by George Speelman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing to do an RC, just updating these files.