Add setup_maas_tigkstack var default to False#414
Merged
tonytan4ever merged 1 commit intorcbops:masterfrom Dec 12, 2017
Merged
Conversation
We shouldn't need to install or setup the tigkstack grafana bits unless we are doing upgrades. As this is causing issues with SNI/SSL on the apt keys for influxdb we should skip installing this. A flag is added (defaulting not defined), so that we can easily enable this for testing downtime on upgrades, setting the "setup_maas_tigkstack" variable to True.
mattt416
approved these changes
Dec 12, 2017
Contributor
mattt416
left a comment
There was a problem hiding this comment.
We still have an underlying Ansible bug w/ SNI, and may need to address later, but I definitely think if this functionality is not being used by customers then we do not need to test it.
mattt416
added a commit
that referenced
this pull request
Dec 12, 2017
In #414 we tried making this include conditional, however this playbook is still being included when run w/ older versions of ansible (1.9.6 as an example). As tigkstack is not something we deploy for customers, this commit removes it from testing entirely.
mattt416
added a commit
that referenced
this pull request
Dec 12, 2017
In #414 we tried making this include conditional, however this playbook is still being included when run w/ older versions of ansible (1.9.6 as an example). Instead, we switch the two `Add influxdata apt-keys` tasks to using the shell module. Using ansible's apt_key fails w/ hosts using SNI (as https://repos.influxdata.com/ appears to be using) because: 1. ansible/ansible#32053 (not backported to 2.3.2.0) 2. ansible 1.9.6 doesn't seem to support SNI on Trusty (python < 2.7.9)
mattt416
added a commit
that referenced
this pull request
Dec 12, 2017
In #414 we tried making this include conditional, however this playbook is still being included when run w/ older versions of ansible (1.9.6 as an example). Instead, we update maas_influxdata_key to have an id and keyserver key. This allows apt_key to work since it doesn't need to speak to https://repos.influxdata.com/ directly. Using ansible's apt_key with https://repos.influxdata.com/ fails because of SNI and: 1. ansible/ansible#32053 (not backported to 2.3.2.0) 2. ansible 1.9.6 doesn't seem to support SNI on Trusty (python < 2.7.9)
cloudnull
pushed a commit
that referenced
this pull request
Dec 13, 2017
In #414 we tried making this include conditional, however this playbook is still being included when run w/ older versions of ansible (1.9.6 as an example). Instead, we update maas_influxdata_key to have an id and keyserver key. This allows apt_key to work since it doesn't need to speak to https://repos.influxdata.com/ directly. Using ansible's apt_key with https://repos.influxdata.com/ fails because of SNI and: 1. ansible/ansible#32053 (not backported to 2.3.2.0) 2. ansible 1.9.6 doesn't seem to support SNI on Trusty (python < 2.7.9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't need to install or setup the tigkstack grafana bits unless
we are doing upgrades. As this is causing issues with SNI/SSL on the apt
keys for influxdb we should skip installing this.
A flag is added (defaulting not defined), so that we can easily enable
this for testing downtime on upgrades, setting the
"setup_maas_tigkstack" variable to True.