Conversation
CrashenX
left a comment
There was a problem hiding this comment.
I don't think we want to remove tigkstack. This is some foundational work @cloudnull did that we will be using as a baseline / reference for Operational Insight. I'll defer to @jedsmith and @cloudnull .
|
This change is probably OK, @CrashenX, because it's just preventing the tests from running. The tests still exist, the way I read it. Happy to be shown I'm wrong. |
CrashenX
left a comment
There was a problem hiding this comment.
I'll unblock. Do we really want tests not to run? AIUI, this IS deployed to customer envs, it's just not enabled by default. Probably want to sync with @npawelek and @cloudnull
|
Hold off on merging this for now -- let's switch the apt_key ansible tasks to using shell commands to bypass the bug ... and we can then let this stuff be deployed/tested as it was. |
|
I can confirm we'd not like to remove it from an RLM perspective, or at least, we have some work in the future to use it during deployments to measure cp downtime, etc. |
|
@mattt416: Just a quick caveat: switching to shell command might break ansible-lint check |
317ab25 to
7070ec8
Compare
Add influxdata apt-keys tasks
39f021d to
1532918
Compare
In #414 we tried making this include conditional, however this playbook is still being included when run w/ older versions of ansible (1.9.6 as an example). Instead, we update maas_influxdata_key to have an id and keyserver key. This allows apt_key to work since it doesn't need to speak to https://repos.influxdata.com/ directly. Using ansible's apt_key with https://repos.influxdata.com/ fails because of SNI and: 1. ansible/ansible#32053 (not backported to 2.3.2.0) 2. ansible 1.9.6 doesn't seem to support SNI on Trusty (python < 2.7.9)
1532918 to
ba12bd5
Compare
Add influxdata apt-keys tasks
In #414 we tried making this include conditional, however this playbook
is still being included when run w/ older versions of ansible (1.9.6
as an example).
Instead, we update maas_influxdata_key to have an id and keyserver key.
This allows apt_key to work since it doesn't need to speak to
https://repos.influxdata.com/ directly. Using ansible's apt_key with
https://repos.influxdata.com/ fails because of SNI and:
2.3.2.0)