[Core] Use Ray ObjectID in Plasma#8852
Merged
suquark merged 5 commits intoray-project:masterfrom Jun 9, 2020
Merged
Conversation
|
Can one of the admins verify this patch? |
ericl
approved these changes
Jun 9, 2020
Member
Author
|
I'll fix java building issues before merge. |
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
Contributor
|
I think this broke the Windows build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR further transforms Plasma as a submodule of Ray. No convention between Ray ObjectIDs and Plasma IDs are necessary in the future. This PR also removes a lot redundant code since Plasma initially come from Ray and then Ray copies code back, and now they are united again.
This PR also addresses an important problem that blocks further integration: the most underlying Ray components depend on Plasma headers, which will cause cyclic reference problems in the future (e.g. when we share states between Plasma and Ray).
Related issue number
Checks
scripts/format.shto lint the changes in this PR.