Skip to content

Fix headers in Bazel#8869

Merged
suquark merged 1 commit intoray-project:masterfrom
mehrdadn:revert-objid
Jun 10, 2020
Merged

Fix headers in Bazel#8869
suquark merged 1 commit intoray-project:masterfrom
mehrdadn:revert-objid

Conversation

@mehrdadn
Copy link
Copy Markdown
Contributor

@mehrdadn mehrdadn commented Jun 9, 2020 •
edited
Loading

Why are these changes needed?

Bazel changes broke the Windows build.

Related issue number

#631, #8852

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jun 9, 2020

Can one of the admins verify this patch?

suquark
suquark approved these changes Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@suquark suquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suquark suquark changed the title Revert "[Core] Use Ray ObjectID in Plasma (#8852)" [Don't merge] Revert "[Core] Use Ray ObjectID in Plasma (#8852)" Jun 9, 2020
@suquark
Copy link
Copy Markdown
Member

suquark commented Jun 9, 2020 •
edited
Loading

we are seeking for a simpler in-place fix. so maybe not merge for now.

@mehrdadn mehrdadn changed the title [Don't merge] Revert "[Core] Use Ray ObjectID in Plasma (#8852)" Fix headers in Bazel Jun 9, 2020
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jun 9, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26959/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Jun 10, 2020

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/26963/
Test PASSed.

@suquark suquark merged commit 4bda333 into ray-project:master Jun 10, 2020
@mehrdadn mehrdadn deleted the revert-objid branch June 10, 2020 02:21
@mehrdadn mehrdadn mentioned this pull request Jun 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suquark suquark suquark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdadn @AmplabJenkins @suquark @web-flow