[ci] upgrade CI test containers from Ubuntu 20.04 to 22.04#61533
[ci] upgrade CI test containers from Ubuntu 20.04 to 22.04#61533
Conversation
|
1dac0b9 to
2f035d8
Compare
There was a problem hiding this comment.
Code Review
This pull request upgrades the CI test containers from Ubuntu 20.04 to 22.04, which is a significant and necessary infrastructure update. The changes across Dockerfiles, configuration files, and test code are mostly correct and well-justified. I have a few suggestions for improvement. First, for better compatibility, I recommend using LLVM binaries specifically built for Ubuntu 22.04. Second, in the documentation, it would be beneficial to retain installation instructions for Podman on Ubuntu 20.04, as it is a widely used LTS release. Lastly, I've suggested a small refactoring in a test file to improve resource management by ensuring a temporary directory is always cleaned up.
2f035d8 to
9de2440
Compare
d47c6a7 to
71222ae
Compare
71222ae to
da86625
Compare
a8a13fe to
aa6c579
Compare
da86625 to
3b35b76
Compare
cd58aef to
5c139b2
Compare
5c139b2 to
eb583c9
Compare
8f1b210 to
f66b067
Compare
8147de2 to
19bd6b1
Compare
f66b067 to
4d398b0
Compare
19bd6b1 to
b250e05
Compare
4d398b0 to
ada6fd6
Compare
4323abf to
73b0d45
Compare
f3d2850 to
c70134e
Compare
73b0d45 to
7cf438c
Compare
aslonnie
left a comment
There was a problem hiding this comment.
could you resolve conflicts?
Upgrades CI test container base images from Ubuntu 20.04 to 22.04 (jammy), including the mandatory clang-12 to clang-14 toolchain upgrade available in 22.04. - focal → jammy for all base images and wanda configs (base.test, base.gpu, base.cu128, forge wanda) - clang-12 → clang-14 in base.test, base.gpu, base.build Dockerfiles and install-llvm-binaries.sh - libncurses5 → libncurses6 - libgl1-mesa-glx → libgl1 (dropped in 22.04) - netcat → netcat-openbsd (22.04 no longer provides the bare netcat metapackage) - mongodb-org apt source: focal → jammy - Java 8 update-alternatives: 22.04 defaults to Java 11, pin to Java 8 where needed - test_dashboard_profiler.py: skip py-spy --native on Linux (known issue, see #30566) - onnx 1.15.0 → 1.16.0 (compatibility with newer environment) - Simplified Podman doc (20.04 workaround removed) Topic: ubuntu-22-04-test Relative: data-mongodb-direct-launch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
14.0.6 does not ship an ubuntu-22.04 tarball (404). No LLVM 14.x release does. Use 14.0.0 with the ubuntu-18.04 tarball, which is glibc backwards-compatible and works on Ubuntu 22.04. Topic: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
The base.test container was missing CC/CXX unlike base.build and base.gpu. Set them explicitly so tools running inside the test container (e.g. test_exported_symbols_unix which builds _raylet via Bazel) use the correct clang-14 compiler. Topic: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
After upgrading from Ubuntu 20.04 (clang-12) to Ubuntu 22.04 (clang-14), early builds with the new ubuntu22.04 image populated the S3 Bazel remote cache with stale .cppmap artifacts under the old ubuntu22.04_py* cache key. Subsequent builds hit those cached entries and failed with undeclared inclusion errors in gRPC/absl targets. Encode the compiler version in RAY_BUILD_ENV (ubuntu22.04_clang14_py*) so the cache key is guaranteed unique and no poisoned entries are reused. RAY_BUILD_ENV is already passed to all Bazel actions via --action_env, making it the correct place to encode incompatible environment changes. Topic: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
… format Ubuntu 22.04's binutils nm (2.38+) emits versioned symbols as symbol@@VERSION_1.0 rather than just symbol. Update the Linux golden file for test_exported_symbols_unix to match. Topic: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
c70134e to
58a676a
Compare
|
conflict resolved |
…ct#61533) Upgrades CI test container base images from Ubuntu 20.04 to 22.04 (jammy), including the mandatory clang-12 to clang-14 toolchain upgrade available in 22.04. - focal → jammy for all base images and wanda configs (base.test, base.gpu, base.cu128, forge wanda) - clang-12 → clang-14 in base.test, base.gpu, base.build Dockerfiles and install-llvm-binaries.sh - libncurses5 → libncurses6 - libgl1-mesa-glx → libgl1 (dropped in 22.04) - netcat → netcat-openbsd (22.04 no longer provides the bare netcat metapackage) - mongodb-org apt source: focal → jammy - Java 8 update-alternatives: 22.04 defaults to Java 11, pin to Java 8 where needed - test_dashboard_profiler.py: skip py-spy --native on Linux (known issue, see ray-project#30566) - onnx 1.15.0 → 1.16.0 (compatibility with newer environment) - Simplified Podman doc (20.04 workaround removed) Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Jeronimo <pedro.jeronimo@tecnico.ulisboa.pt>
…ct#61533) Upgrades CI test container base images from Ubuntu 20.04 to 22.04 (jammy), including the mandatory clang-12 to clang-14 toolchain upgrade available in 22.04. - focal → jammy for all base images and wanda configs (base.test, base.gpu, base.cu128, forge wanda) - clang-12 → clang-14 in base.test, base.gpu, base.build Dockerfiles and install-llvm-binaries.sh - libncurses5 → libncurses6 - libgl1-mesa-glx → libgl1 (dropped in 22.04) - netcat → netcat-openbsd (22.04 no longer provides the bare netcat metapackage) - mongodb-org apt source: focal → jammy - Java 8 update-alternatives: 22.04 defaults to Java 11, pin to Java 8 where needed - test_dashboard_profiler.py: skip py-spy --native on Linux (known issue, see ray-project#30566) - onnx 1.15.0 → 1.16.0 (compatibility with newer environment) - Simplified Podman doc (20.04 workaround removed) Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Upgrades CI test container base images from Ubuntu 20.04 to 22.04 (jammy), including the mandatory clang-12 to clang-14 toolchain upgrade available in 22.04.
--nativeoption is used #30566)Topic: ubuntu-22-04-test
Relative: data-mongodb-direct-launch
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com