[ci] Upgrade forge Dockerfiles from clang-12 to clang-14#61662
Merged
[ci] Upgrade forge Dockerfiles from clang-12 to clang-14#61662
Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
This was referenced Mar 11, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades clang from version 12 to 14 in the forge Dockerfiles for arm64 and x86_64 architectures. The changes are correct and align with the goal of standardizing the clang version across CI images. I've added a few suggestions to improve the Dockerfiles by following best practices, such as chaining apt-get commands to reduce layer size and creating a symlink for clang++ for consistency with clang.
5252a8a to
4b1bd38
Compare
8f1b210 to
f66b067
Compare
4b1bd38 to
30c39dc
Compare
f66b067 to
4d398b0
Compare
30c39dc to
1ee09b2
Compare
4d398b0 to
ada6fd6
Compare
1ee09b2 to
741e017
Compare
ada6fd6 to
f3d2850
Compare
f3d2850 to
c70134e
Compare
741e017 to
acd2d9d
Compare
c70134e to
58a676a
Compare
acd2d9d to
600cc8a
Compare
Base automatically changed from
andrew/revup/master/ubuntu-22-04-test
to
master
March 18, 2026 00:42
aslonnie
approved these changes
Mar 18, 2026
The forge wanda configs were updated to ubuntu:22.04 but the corresponding Dockerfiles still installed clang-12, creating a mismatch with CI test images (base.test, base.gpu, base.build) which all use clang-14 on 22.04. Topic: forge-clang-14 Relative: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com>
d9d35e7 to
97c9821
Compare
dayshah
approved these changes
Mar 18, 2026
edoakes
approved these changes
Mar 18, 2026
pedrojeronim0
pushed a commit
to pedrojeronim0/ray
that referenced
this pull request
Mar 23, 2026
…#61662) The forge wanda configs were updated to ubuntu:22.04 but the corresponding Dockerfiles still installed clang-12, creating a mismatch with CI test images (base.test, base.gpu, base.build) which all use clang-14 on 22.04. Topic: forge-clang-14 Relative: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Jeronimo <pedro.jeronimo@tecnico.ulisboa.pt>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Mar 25, 2026
…#61662) The forge wanda configs were updated to ubuntu:22.04 but the corresponding Dockerfiles still installed clang-12, creating a mismatch with CI test images (base.test, base.gpu, base.build) which all use clang-14 on 22.04. Topic: forge-clang-14 Relative: ubuntu-22-04-test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forge wanda configs were updated to ubuntu:22.04 but the corresponding
Dockerfiles still installed clang-12, creating a mismatch with CI test
images (base.test, base.gpu, base.build) which all use clang-14 on 22.04.
Topic: forge-clang-14
Relative: ubuntu-22-04-test
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: andrew andrew@anyscale.com