[data] Remove dead FastFileMetadataProvider code by rushikeshadhav · Pull Request #59027 · ray-project/ray

rushikeshadhav · 2025-11-27T05:48:14Z

Description

After removing the deprecated read_parquet_bulk API, FastFileMetadataProvider became dead code with no remaining usage in the codebase.

This commit removes:

FastFileMetadataProvider class implementation
All imports and exports of FastFileMetadataProvider
Tests that specifically tested FastFileMetadataProvider
Documentation references to FastFileMetadataProvider
Code comments mentioning FastFileMetadataProvider

Related issues

Fixes #59010

gemini-code-assist

Code Review

This pull request does a great job of removing the dead code for FastFileMetadataProvider. The changes are clean and cover all necessary areas including implementation, documentation, and tests. I have one suggestion to improve a test that becomes a bit confusing after the code removal.

python/ray/data/tests/test_csv.py

python/ray/data/tests/test_image.py

python/ray/data/tests/test_json.py

python/ray/data/tests/test_numpy.py

python/ray/data/tests/test_text.py

python/ray/data/tests/test_binary.py

owenowenisme · 2025-11-30T18:52:17Z

Thanks for your contribution!
Left some comments that need to be addressed, thanks!

bveeramani · 2025-12-09T10:15:09Z

Hey @rushikeshadhav, just checking in on this when you get a chance

cursor

Bug: Test execution code removed instead of replaced with alternative (Bugbot Rules)

The test_read_binary_meta_provider test function has its main positive test case removed entirely. The code that reads binary files with FastFileMetadataProvider and asserts the result was deleted, leaving only the setup code and the negative pytest.raises test. Per reviewer comment, this functionality needs to be preserved using DefaultFileMetadataProvider() instead of simply deleting the test execution.

python/ray/data/tests/test_binary.py#L88-L89

ray/python/ray/data/tests/test_binary.py

Lines 88 to 89 in 079fdc7

	snappy.stream_compress(bytes, f)

rushikeshadhav · 2025-12-09T17:22:03Z

@owenowenisme , I have made the required changes, please check

rushikeshadhav · 2025-12-09T17:22:58Z

Hey @rushikeshadhav, just checking in on this when you get a chance

Thanks for the heads up, I have resolved the comments

github-actions · 2025-12-24T00:41:07Z

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

After removing the deprecated read_parquet_bulk API, FastFileMetadataProvider became dead code with no remaining usage in the codebase. This commit removes: - FastFileMetadataProvider class implementation - All imports and exports of FastFileMetadataProvider - Tests that specifically tested FastFileMetadataProvider - Documentation references to FastFileMetadataProvider - Code comments mentioning FastFileMetadataProvider The class was previously used as a faster alternative to DefaultFileMetadataProvider that skipped directory expansion and file size collection, but it's no longer needed after the bulk API removal. Signed-off-by: rushikesh.adhav <adhavrushikesh6@gmail.com>

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>

owenowenisme

LGTM

## Description After removing the deprecated `read_parquet_bulk` API, `FastFileMetadataProvider` became dead code with no remaining usage in the codebase. This commit removes: - FastFileMetadataProvider class implementation - All imports and exports of FastFileMetadataProvider - Tests that specifically tested FastFileMetadataProvider - Documentation references to FastFileMetadataProvider - Code comments mentioning FastFileMetadataProvider ## Related issues > Fixes ray-project#59010 --------- Signed-off-by: rushikesh.adhav <adhavrushikesh6@gmail.com> Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>

…es (#60084) (#60091) Categorize APIs into Public APIs and Developer APIs, and sort them alphabetically by service name. Changes: - Reorganized loading_data.rst and saving_data.rst with Public APIs first, then Developer APIs - Sorted all APIs alphabetically by service name within each section - Sections that originally had APIs for both Public and Developer APIs were divided to respective sections - Removed datasource.FastFileMetadataProvider API that has been removed ([reference](#59027)) Fixes #60084 Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> --------- Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: mgchoi239 <mg.choi.239@gmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>

…es (ray-project#60084) (ray-project#60091) Categorize APIs into Public APIs and Developer APIs, and sort them alphabetically by service name. Changes: - Reorganized loading_data.rst and saving_data.rst with Public APIs first, then Developer APIs - Sorted all APIs alphabetically by service name within each section - Sections that originally had APIs for both Public and Developer APIs were divided to respective sections - Removed datasource.FastFileMetadataProvider API that has been removed ([reference](ray-project#59027)) Fixes ray-project#60084 Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> --------- Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: mgchoi239 <mg.choi.239@gmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>

## Description After removing the deprecated `read_parquet_bulk` API, `FastFileMetadataProvider` became dead code with no remaining usage in the codebase. This commit removes: - FastFileMetadataProvider class implementation - All imports and exports of FastFileMetadataProvider - Tests that specifically tested FastFileMetadataProvider - Documentation references to FastFileMetadataProvider - Code comments mentioning FastFileMetadataProvider ## Related issues > Fixes ray-project#59010 --------- Signed-off-by: rushikesh.adhav <adhavrushikesh6@gmail.com> Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>

…es (ray-project#60084) (ray-project#60091) Categorize APIs into Public APIs and Developer APIs, and sort them alphabetically by service name. Changes: - Reorganized loading_data.rst and saving_data.rst with Public APIs first, then Developer APIs - Sorted all APIs alphabetically by service name within each section - Sections that originally had APIs for both Public and Developer APIs were divided to respective sections - Removed datasource.FastFileMetadataProvider API that has been removed ([reference](ray-project#59027)) Fixes ray-project#60084 Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> --------- Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: mgchoi239 <mg.choi.239@gmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>

## Description After removing the deprecated `read_parquet_bulk` API, `FastFileMetadataProvider` became dead code with no remaining usage in the codebase. This commit removes: - FastFileMetadataProvider class implementation - All imports and exports of FastFileMetadataProvider - Tests that specifically tested FastFileMetadataProvider - Documentation references to FastFileMetadataProvider - Code comments mentioning FastFileMetadataProvider ## Related issues > Fixes ray-project#59010 --------- Signed-off-by: rushikesh.adhav <adhavrushikesh6@gmail.com> Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>

…es (ray-project#60084) (ray-project#60091) Categorize APIs into Public APIs and Developer APIs, and sort them alphabetically by service name. Changes: - Reorganized loading_data.rst and saving_data.rst with Public APIs first, then Developer APIs - Sorted all APIs alphabetically by service name within each section - Sections that originally had APIs for both Public and Developer APIs were divided to respective sections - Removed datasource.FastFileMetadataProvider API that has been removed ([reference](ray-project#59027)) Fixes ray-project#60084 Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> --------- Signed-off-by: mgchoi239 <mg.choi.239@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: mgchoi239 <mg.choi.239@gmail.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>

rushikeshadhav requested a review from a team as a code owner November 27, 2025 05:48

gemini-code-assist bot reviewed Nov 27, 2025

View reviewed changes

ray-gardener bot added docs An issue or change related to documentation data Ray Data-related issues community-contribution Contributed by the community labels Nov 27, 2025

owenowenisme reviewed Nov 30, 2025

View reviewed changes

omatthew98 added the @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. label Dec 3, 2025

rushikeshadhav force-pushed the remove-fast-file-metadata-provider branch from d7013d6 to 079fdc7 Compare December 9, 2025 17:11

cursor bot reviewed Dec 9, 2025

View reviewed changes

github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 24, 2025

rushikeshadhav added 3 commits December 27, 2025 14:00

fix: use DefaultFileMetadataProvider

ea42468

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>

fix: use DefaultFileMetadataProvider in test_binary

63e2a8f

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>

rushikeshadhav force-pushed the remove-fast-file-metadata-provider branch from 6f79618 to 63e2a8f Compare December 27, 2025 08:32

owenowenisme added go add ONLY when ready to merge, run all tests and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Dec 27, 2025

owenowenisme approved these changes Dec 27, 2025

View reviewed changes

bveeramani merged commit 639451f into ray-project:master Dec 28, 2025
7 checks passed

mgchoi239 mentioned this pull request Jan 14, 2026

[Data][Docs] Sort references in Loading data and Saving data references (#60084) #60091

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data] Remove dead FastFileMetadataProvider code#59027

[data] Remove dead FastFileMetadataProvider code#59027
bveeramani merged 3 commits intoray-project:masterfrom
rushikeshadhav:remove-fast-file-metadata-provider

rushikeshadhav commented Nov 27, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owenowenisme commented Nov 30, 2025

Uh oh!

bveeramani commented Dec 9, 2025

Uh oh!

cursor bot left a comment

Uh oh!

rushikeshadhav commented Dec 9, 2025

Uh oh!

rushikeshadhav commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

owenowenisme left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rushikeshadhav commented Nov 27, 2025

Description

Related issues

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owenowenisme commented Nov 30, 2025

Uh oh!

bveeramani commented Dec 9, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Test execution code removed instead of replaced with alternative (Bugbot Rules)

Uh oh!

rushikeshadhav commented Dec 9, 2025

Uh oh!

rushikeshadhav commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

owenowenisme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants