[Doc][Serve] Import AutoscalingContext in autoscaling policy example#57876
Merged
abrarsheikh merged 1 commit intoray-project:masterfrom Oct 20, 2025
Merged
[Doc][Serve] Import AutoscalingContext in autoscaling policy example#57876abrarsheikh merged 1 commit intoray-project:masterfrom
abrarsheikh merged 1 commit intoray-project:masterfrom
Conversation
Change-Id: Ie4e7e5d53a882b4eafcc85513822f095068be816 Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Contributor
There was a problem hiding this comment.
Code Review
This PR correctly adds the missing AutoscalingContext import to the coordinated_scaling_policy documentation example, making it self-contained. I've suggested a minor improvement to sort the imports according to PEP 8. I also noticed that the custom_metrics_autoscaling_policy example in the same file is missing imports for AutoscalingContext, Dict, and Any. Addressing this would make all examples in the file complete.
abrarsheikh
approved these changes
Oct 19, 2025
Contributor
|
on a second though could you also add appropriate imports to the custom metrics policy code block https://anyscale-ray--57876.com.readthedocs.build/en/57876/serve/advanced-guides/advanced-autoscaling.html#custom-metrics |
Contributor
Author
Sure! Modification in PR #57896. |
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: xgui <xgui@anyscale.com>
abrarsheikh
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: #57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ay-project#57876) ## Description ## Related issues Closes ray-project#57847 ## Additional information Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Closes #57847
Additional information