[Doc][Serve] Add missing imports to autoscaling policy example#57896
Merged
abrarsheikh merged 2 commits intoray-project:masterfrom Oct 27, 2025
Merged
[Doc][Serve] Add missing imports to autoscaling policy example#57896abrarsheikh merged 2 commits intoray-project:masterfrom
abrarsheikh merged 2 commits intoray-project:masterfrom
Conversation
Change-Id: I1332b0e68caea3f3f27b3da70ceffb3f581d62a9 Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds missing imports to the autoscaling policy examples in the documentation, making the code snippets self-contained and runnable. My review includes a minor suggestion to improve the import order in one of the snippets to adhere to PEP 8 standards for better code organization and readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn>
abrarsheikh
approved these changes
Oct 27, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…roject#57896) ## Description Add missing imports to autoscaling policy example ## Related issues Link related issues: ray-project#57876 (comment) --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: Ping Dai <dai.ping88@zte.com.cn> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing imports to autoscaling policy example
Related issues
Link related issues: #57876 (comment)